You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove units from the mosaic level pipeline. This involves updates to rad (removing units from schemas), roman_datamodels (removing units from the data models) and romancal (removing units from the pipeline). The mosaic level pipeline uses fewer units than the ELP, so my expectation is that this will be much less involved than there. I believe it uses no reference files with units (though the photmjysr column in the ELP files carry units), so that will also make it easier. We should assume for the moment that that column will continue to have units, and so the mosaic level pipeline should remove them via .value; a later update to the ELP will remove those updates and require an update to the mosaic level pipeline to compensate.
I've given the epic as mosaic images in B15 since this touches the HLP, but we should migrate to a B16 epic when available.
The text was updated successfully, but these errors were encountered:
We are removing units from the data arrays, i.e. removing quantities from the files. However, the data units is valuable information. How is this info stored in the files or is it TBD?
TBD. Tyler and I talked a little about this. We are going to continue to have it in the rad schemas following Brett's suggestion here: spacetelescope/rad#438
Brett gives an example of how to access that information for Roman data models. It seems to me that the schema contains enough information that we should consider putting the whole thing in the asdf files, rather than just a link, if we do not currently do that.
Issue RCAL-911 was created on JIRA by Eddie Schlafly:
Remove units from the mosaic level pipeline. This involves updates to rad (removing units from schemas), roman_datamodels (removing units from the data models) and romancal (removing units from the pipeline). The mosaic level pipeline uses fewer units than the ELP, so my expectation is that this will be much less involved than there. I believe it uses no reference files with units (though the photmjysr column in the ELP files carry units), so that will also make it easier. We should assume for the moment that that column will continue to have units, and so the mosaic level pipeline should remove them via .value; a later update to the ELP will remove those updates and require an update to the mosaic level pipeline to compensate.
I've given the epic as mosaic images in B15 since this touches the HLP, but we should migrate to a B16 epic when available.
The text was updated successfully, but these errors were encountered: