rcal-920 script to create associations based on skycells #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddavis-stsci
force-pushed
the
rcal-920_dsd
branch
from
e097575
to
851697d
Compare
braingram
reviewed
Oct 3, 2024
Comment on lines
10
to
16
| def passfail(bool_expr): | ||
| """set pass fail""" | ||
| if bool_expr: | ||
| return "Pass" | ||
| return "Fail" | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| def passfail(bool_expr): | |
| """set pass fail""" | |
| if bool_expr: | |
| return "Pass" | |
| return "Fail" |
No longer needed with the suggestion below: #1437 (comment)
braingram
reviewed
Oct 3, 2024
Comment on lines
44
to
47
| for file in output_files: | ||
| skycell_asn.logger.info( | ||
| "Check that the json file exists " + passfail(os.path.isfile(file)) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| for file in output_files: | |
| skycell_asn.logger.info( | |
| "Check that the json file exists " + passfail(os.path.isfile(file)) | |
| ) | |
| missing_files = [fn for fn in output_files if not os.path.isfile(fn)] | |
| assert not missing_files, f"Missing files: {missing_files}" |
How does this look for an assert to add to this test? Without an assert that checks there are no missing files the test can silently pass if one or all of the files are missing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 78.38% 78.09% -0.29%
==========================================
Files 118 119 +1
Lines 7680 7744 +64
==========================================
+ Hits 6020 6048 +28
- Misses 1660 1696 +36
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ddavis-stsci
force-pushed
the
rcal-920_dsd
branch
from
4abb264
to
aaa158b
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-920
Closes #1421
This PR adds code to take an input list of calibrated WFI exposures and creates associations based on the
skycells that they overlap.
Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth filesRegression test results are at
https://github.com/spacetelescope/RegressionTests/actions/runs/11168259268
news fragment change types...
changes/<PR#>.general.rst: infrastructure or miscellaneous changechanges/<PR#>.docs.rstchanges/<PR#>.stpipe.rstchanges/<PR#>.associations.rstchanges/<PR#>.scripts.rstchanges/<PR#>.mosaic_pipeline.rstchanges/<PR#>.patch_match.rststeps
changes/<PR#>.dq_init.rstchanges/<PR#>.saturation.rstchanges/<PR#>.refpix.rstchanges/<PR#>.linearity.rstchanges/<PR#>.dark_current.rstchanges/<PR#>.jump_detection.rstchanges/<PR#>.ramp_fitting.rstchanges/<PR#>.assign_wcs.rstchanges/<PR#>.flatfield.rstchanges/<PR#>.photom.rstchanges/<PR#>.flux.rstchanges/<PR#>.source_detection.rstchanges/<PR#>.tweakreg.rstchanges/<PR#>.skymatch.rstchanges/<PR#>.outlier_detection.rstchanges/<PR#>.resample.rstchanges/<PR#>.source_catalog.rst