Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align message type usage (BC) #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

andig
Copy link
Contributor

@andig andig commented Nov 29, 2024

Fix #69

@andig andig changed the title Align message type usage Align message type usage (BC) Nov 29, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes missing coverage. Please review.

Project coverage is 47.58%. Comparing base (6020765) to head (054db9d).

Files with missing lines Patch % Lines
cmd/example/e3dc.go 0.00% 9 Missing ⚠️
rscp/client.go 0.00% 6 Missing ⚠️
cmd/e3dc/e3dc.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   47.83%   47.58%   -0.26%     
==========================================
  Files          28       28              
  Lines        1315     1303      -12     
==========================================
- Hits          629      620       -9     
+ Misses        652      649       -3     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spali spali added breaking change enhancement New feature or request labels Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Send vs SendMultiple vs NewMessage
3 participants