Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict typeCheckingMode #413

Closed
wants to merge 21 commits into from
Closed

Add strict typeCheckingMode #413

wants to merge 21 commits into from

Conversation

ddungiii
Copy link
Member

진행 방법

  • refactor/type-hint-{nickname} 브랜치로 나누어 가주세요
  • pylance에서 찾아주는 모든 error를 수정합니다.
    • 에러는 mypy . 으로 확인할 수 있습니다.

진행상황

ddungiii and others added 12 commits September 14, 2023 15:28
Add stubs to fix mypy typehint errors
mypy.ini follow_imports not exists in mypy settings
using vscode:extension/matangover.mypy to lint the codes.
Added types about bleach, python-tateutil, tqdm.
Ignored boto3, django_filters, celery, firebase_admin, environ,
django_elasticsearch_dsl, elasticsearch_dsl
…tubs

feat(mypy): add stubs to remove mypy linting errors
@DoyunShin DoyunShin linked an issue Oct 5, 2023 that may be closed by this pull request
@DoyunShin
Copy link
Member

type-hint-{username}로 되어있는 모든 브랜치를 type-hint로 머지 한 후 여기에서 리뷰를 진행하겠습니다.

@DoyunShin DoyunShin requested review from injoonH and removed request for injoonH October 5, 2023 15:57
@DoyunShin
Copy link
Member

현재 Mypy가 django 내부 함수들을 잡는 문제점들이 있습니다. 이에 대해 어떻게 해결하는게 좋을까요?

  1. mypy를 쓰지 않는다. - Any가 나오는것에 대해 메뉴얼로 타입힌팅을 진행한다. (일단 현재 이대로 진행중임)
  2. mypy를 고친다.
  3. 다른 확인툴을 쓴다.

@DoyunShin DoyunShin marked this pull request as ready for review October 26, 2023 15:30
@DoyunShin DoyunShin requested a review from injoonH October 26, 2023 15:33
{
"mypy.enabled": true,
"mypy.configFile": "mypy.ini",
"mypy.dmypyExecutable": "/root/.local/share/virtualenvs/www-ZVUe9YDU/bin/dmypy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 경로는 사람마다 달라서 다른 방식으로 넣는 게 나을 것 같습니다.

apps/core/management/scripts/portal_crawler.py Outdated Show resolved Hide resolved
apps/core/management/scripts/portal_crawler.py Outdated Show resolved Hide resolved
apps/core/management/scripts/portal_crawler.py Outdated Show resolved Hide resolved
apps/core/models/article.py Outdated Show resolved Hide resolved
apps/core/models/article.py Outdated Show resolved Hide resolved
apps/core/models/article.py Outdated Show resolved Hide resolved
apps/core/models/article.py Show resolved Hide resolved
apps/core/models/comment.py Outdated Show resolved Hide resolved
@injoonH injoonH closed this Mar 11, 2024
@injoonH injoonH deleted the refactor/type-hint branch March 11, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use type hints strictly
4 participants