Merge pull request #23 from sparingsoftware/feat/a11y-rules

feat: Add a11y rules to configs

Author: Haxikowy

astro.js

@@ -1,6 +1,10 @@
 /** @type {import("eslint").Linter.Config}  */
 module.exports = {
-  extends: ['plugin:astro/recommended', '@sparing-software/eslint-config'],
+  extends: [
+    'plugin:astro/recommended',
+    'plugin:astro/jsx-a11y-recommended',
+    '@sparing-software/eslint-config'
+  ],
   overrides: [
     {
       files: ['*.astro'],
@@ -10,7 +14,20 @@ module.exports = {
         extraFileExtensions: ['.astro']
       },
       rules: {
-        // All rules: https://ota-meshi.github.io/eslint-plugin-astro/rules/
+        // All rules: https://ota-meshi.github.io/eslint-plugin-astro/rules/,
+        'astro/jsx-a11y/alt-text': [
+          'error',
+          {
+            elements: ['img', 'object', 'area'],
+            img: ['Image']
+          }
+        ],
+        'astro/jsx-a11y/img-redundant-alt': [
+          'error',
+          {
+            components: ['Image']
+          }
+        ]
       }
     }
   ],

next.js

@@ -1,34 +1,12 @@
 /** @type {import("eslint").Linter.Config}  */
 const next = {
-  extends: ['next', 'next/core-web-vitals', '@sparing-software/eslint-config'],
+  extends: [
+    'next/core-web-vitals',
+    'plugin:jsx-a11y/recommended',
+    '@sparing-software/eslint-config'
+  ],
+  plugins: ['jsx-a11y'],
   rules: {
-    'import/order': [
-      'warn',
-      {
-        groups: [
-          'builtin',
-          'external',
-          'internal',
-          ['parent', 'sibling', 'index']
-        ],
-        alphabetize: {
-          order: 'asc'
-        },
-        pathGroups: [
-          {
-            pattern: '@/styles/**',
-            group: 'internal',
-            position: 'after'
-          },
-          {
-            pattern: '@/**',
-            group: 'internal',
-            position: 'before'
-          }
-        ],
-        'newlines-between': 'always'
-      }
-    ],
     'react/self-closing-comp': [
       'warn',
       {
@@ -42,7 +20,31 @@ const next = {
       { props: 'never', children: 'ignore' }
     ],
     'react/jsx-boolean-value': ['warn', 'never'],
-    'react/jsx-no-leaked-render': 'error'
+    'react/jsx-no-leaked-render': 'error',
+    'jsx-a11y/alt-text': [
+      'error',
+      {
+        img: ['Image']
+      }
+    ],
+    'jsx-a11y/img-redundant-alt': [
+      'error',
+      {
+        components: ['Image']
+      }
+    ],
+    'jsx-a11y/anchor-has-content': [
+      'error',
+      {
+        components: ['Link']
+      }
+    ],
+    'jsx-a11y/anchor-is-valid': [
+      'error',
+      {
+        components: ['Link']
+      }
+    ]
   }
 }
 

nuxt.js

@@ -3,7 +3,21 @@ const nuxtEslintConfig = require('@nuxt/eslint-config')
 /** @type {import("eslint").Linter.Config}  */
 const nuxt = {
   extends: ['@nuxt/eslint-config', '@sparing-software/eslint-config/vue'],
-  overrides: [...nuxtEslintConfig.overrides]
+  overrides: [...nuxtEslintConfig.overrides],
+  rules: {
+    'vuejs-accessibility/alt-text': [
+      'error',
+      {
+        img: ['NuxtImg', 'NuxtPicture']
+      }
+    ],
+    'vuejs-accessibility/anchor-has-content': [
+      'error',
+      {
+        components: ['RouterLink', 'NuxtLink']
+      }
+    ]
+  }
 }
 
 module.exports = nuxt