Merge pull request #19 from sparingsoftware/feat/FRN-173/add-new-eslint-rules

feat: Add new eslint rules FRN-173

Author: fglowicki

index.js

@@ -1,6 +1,10 @@
 /** @type {import("eslint").Linter.Config}  */
 const defaultConfig = {
-  extends: ['plugin:@typescript-eslint/recommended', 'prettier'],
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+    'prettier'
+  ],
   plugins: ['import', 'unicorn'],
   rules: {
     'no-restricted-syntax': [
@@ -17,7 +21,6 @@ const defaultConfig = {
     'prefer-destructuring': ['warn', { object: false, array: true }],
     'no-multiple-empty-lines': ['error', { max: 2 }],
     'object-shorthand': ['warn', 'always'],
-    'unicorn/prefer-ternary': 'warn',
     'import/newline-after-import': ['warn', { count: 1 }],
     'import/order': [
       'warn',
@@ -56,7 +59,27 @@ const defaultConfig = {
         assertionStyle: 'as',
         objectLiteralTypeAssertions: 'allow-as-parameter'
       }
-    ]
+    ],
+    '@typescript-eslint/prefer-nullish-coalescing': 'warn',
+    'unicorn/prefer-ternary': 'warn',
+    'unicorn/prefer-negative-index': 'warn',
+    'unicorn/prefer-at': 'warn',
+    'unicorn/prefer-switch': 'warn',
+    'unicorn/switch-case-braces': ['warn', 'avoid'],
+    'unicorn/consistent-destructuring': 'warn',
+    'unicorn/no-useless-undefined': 'warn',
+    'unicorn/expiring-todo-comments': 'warn',
+    'unicorn/require-array-join-separator': 'warn'
+  },
+  /*
+    Rule @typescript-eslint/prefer-nullish-coalescing - require parserOptions reason:
+    Error while loading rule '@typescript-eslint/prefer-nullish-coalescing':
+    You have used a rule which requires parserServices to be generated. 
+    You must therefore provide a value for the "parserOptions.project"
+  */
+  parserOptions: {
+    parser: '@typescript-eslint/parser',
+    project: true
   }
 }
 

package-lock.json

@@ -38,11 +38,11 @@
     "@vue/eslint-config-typescript": "^13.0.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-import-resolver-babel-module": "^5.3.2",
-    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-prettier": "^5.1.3",
     "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-vue": "^9.25.0",
     "eslint-plugin-unicorn": "^52.0.0",
-    "eslint-plugin-vue": "^9.25.0"
+    "eslint-plugin-import": "^2.29.1"
   },
   "devDependencies": {
     "@commitlint/cli": "^19.2.2",

package.json

@@ -4,11 +4,17 @@ const defaultConfig = require('./index')
 const vue = {
   extends: [
     'plugin:vue/vue3-recommended',
-    'eslint:recommended',
     '@sparing-software/eslint-config',
     '@vue/eslint-config-typescript/recommended'
   ],
+  /* 
+    This parser safe us from extra eslint problem after
+    adding @typescript-eslint/prefer-nullish-coalescing flag into index.js
+    https://stackoverflow.com/a/66598327 
+  */
+  parser: 'vue-eslint-parser',
   parserOptions: {
+    ...defaultConfig.parserOptions,
     ecmaVersion: 'latest'
   },
   rules: {