@@ -10377,10 +10377,7 @@ bool SFE_UBLOX_GNSS::getNAVEOE(uint16_t maxWait)
1037710377 }
1037810378 else
1037910379 {
10380- // if (_printDebug == true)
10381- // {
10382- // _debugSerial->println(F("getEOE: Polling"));
10383- // }
10380+ // Note to self: NAV-EOE is "Periodic" (only). Not sure if it can be polled?
1038410381
1038510382 // The GPS is not automatically reporting navigation position so we have to poll explicitly
1038610383 packetCfg.cls = UBX_CLASS_NAV;
@@ -10396,18 +10393,9 @@ bool SFE_UBLOX_GNSS::getNAVEOE(uint16_t maxWait)
1039610393
1039710394 if (retVal == SFE_UBLOX_STATUS_DATA_OVERWRITTEN)
1039810395 {
10399- // if (_printDebug == true)
10400- // {
10401- // _debugSerial->println(F("getEOE: data in packetCfg was OVERWRITTEN by another message (but that's OK)"));
10402- // }
1040310396 return (true);
1040410397 }
1040510398
10406- // if (_printDebug == true)
10407- // {
10408- // _debugSerial->print(F("getEOE retVal: "));
10409- // _debugSerial->println(statusString(retVal));
10410- // }
1041110399 return (false);
1041210400 }
1041310401}
@@ -13487,14 +13475,14 @@ bool SFE_UBLOX_GNSS::initPacketUBXRXMCOR()
1348713475bool SFE_UBLOX_GNSS::getRXMSFRBX(uint16_t maxWait)
1348813476{
1348913477 if (packetUBXRXMSFRBX == NULL)
13490- initPacketUBXRXMSFRBX(); // Check that RAM has been allocated for the TM2 data
13478+ initPacketUBXRXMSFRBX(); // Check that RAM has been allocated for the SFRBX data
1349113479 if (packetUBXRXMSFRBX == NULL) // Bail if the RAM allocation failed
1349213480 return (false);
1349313481
1349413482 if (packetUBXRXMSFRBX->automaticFlags.flags.bits.automatic && packetUBXRXMSFRBX->automaticFlags.flags.bits.implicitUpdate)
1349513483 {
1349613484 // The GPS is automatically reporting, we just check whether we got unread data
13497- checkUbloxInternal(&packetCfg, UBX_CLASS_TIM, UBX_TIM_TM2 );
13485+ checkUbloxInternal(&packetCfg, UBX_CLASS_RXM, UBX_RXM_SFRBX );
1349813486 return packetUBXRXMSFRBX->moduleQueried;
1349913487 }
1350013488 else if (packetUBXRXMSFRBX->automaticFlags.flags.bits.automatic && !packetUBXRXMSFRBX->automaticFlags.flags.bits.implicitUpdate)
@@ -13504,23 +13492,9 @@ bool SFE_UBLOX_GNSS::getRXMSFRBX(uint16_t maxWait)
1350413492 }
1350513493 else
1350613494 {
13507- // The GPS is not automatically reporting navigation position so we have to poll explicitly
13508- packetCfg.cls = UBX_CLASS_RXM;
13509- packetCfg.id = UBX_RXM_SFRBX;
13510- packetCfg.len = 0;
13511- packetCfg.startingSpot = 0;
13512-
13513- // The data is parsed as part of processing the response
13514- sfe_ublox_status_e retVal = sendCommand(&packetCfg, maxWait);
13515-
13516- if (retVal == SFE_UBLOX_STATUS_DATA_RECEIVED)
13517- return (true);
13518-
13519- if (retVal == SFE_UBLOX_STATUS_DATA_OVERWRITTEN)
13520- {
13521- return (true);
13522- }
13523-
13495+ // SFRBX is output-only. It cannot be polled...
13496+ // Strictly, getRXMSFRBX should be deprecated. But, to keep the library backward compatible, return(false) here.
13497+ // See issue #167 for details
1352413498 return (false);
1352513499 }
1352613500}
@@ -13679,14 +13653,14 @@ void SFE_UBLOX_GNSS::logRXMSFRBX(bool enabled)
1367913653bool SFE_UBLOX_GNSS::getRXMRAWX(uint16_t maxWait)
1368013654{
1368113655 if (packetUBXRXMRAWX == NULL)
13682- initPacketUBXRXMRAWX(); // Check that RAM has been allocated for the TM2 data
13656+ initPacketUBXRXMRAWX(); // Check that RAM has been allocated for the RAWX data
1368313657 if (packetUBXRXMRAWX == NULL) // Bail if the RAM allocation failed
1368413658 return (false);
1368513659
1368613660 if (packetUBXRXMRAWX->automaticFlags.flags.bits.automatic && packetUBXRXMRAWX->automaticFlags.flags.bits.implicitUpdate)
1368713661 {
1368813662 // The GPS is automatically reporting, we just check whether we got unread data
13689- checkUbloxInternal(&packetCfg, UBX_CLASS_TIM, UBX_TIM_TM2 );
13663+ checkUbloxInternal(&packetCfg, UBX_CLASS_RXM, UBX_RXM_RAWX );
1369013664 return packetUBXRXMRAWX->moduleQueried;
1369113665 }
1369213666 else if (packetUBXRXMRAWX->automaticFlags.flags.bits.automatic && !packetUBXRXMRAWX->automaticFlags.flags.bits.implicitUpdate)
0 commit comments