Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peak_score.csv should probably have k_neigh_avg instead of density #131

Open
sgbaird opened this issue Dec 12, 2022 · 0 comments
Open

peak_score.csv should probably have k_neigh_avg instead of density #131

sgbaird opened this issue Dec 12, 2022 · 0 comments
Assignees
@sgbaird
Labels
bug Something isn't working

Comments

@sgbaird
Copy link
Member

sgbaird commented Dec 12, 2022

Based on discussion with @hasan-sayeed

See e.g. the tutorial notebook:

disc.dens_score_df.head(10)

image

disc.peak_score_df.head(10)

image

Peak score is calculated from the kNN averages, so it's confusing that density is one of the columns in the output dataframe.
@sgbaird sgbaird added the bug Something isn't working label Dec 12, 2022
@sgbaird sgbaird self-assigned this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgbaird sgbaird

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgbaird