fix addresses not working without the name of the address

Author: rubenvanassche

.phpunit.result.cache

@@ -0,0 +1 @@
+C:37:"PHPUnit\Runner\DefaultTestResultCache":7259:{a:2:{s:7:"defects";a:0:{}s:5:"times";a:65:{s:111:"Spatie\IcalendarGenerator\Tests\Builders\ComponentBuilderTest::it_can_build_a_component_payload_with_properties";d:0.004;s:115:"Spatie\IcalendarGenerator\Tests\Builders\ComponentBuilderTest::it_can_build_a_component_payload_with_property_alias";d:0;s:114:"Spatie\IcalendarGenerator\Tests\Builders\ComponentBuilderTest::it_can_build_a_component_payload_with_subcomponents";d:0.001;s:107:"Spatie\IcalendarGenerator\Tests\Builders\ComponentBuilderTest::it_will_chip_a_line_when_it_becomes_too_long";d:0;s:98:"Spatie\IcalendarGenerator\Tests\Builders\PropertyBuilderTest::it_will_build_the_property_correctly";d:0;s:100:"Spatie\IcalendarGenerator\Tests\Builders\PropertyBuilderTest::it_will_build_the_parameters_correctly";d:0;s:116:"Spatie\IcalendarGenerator\Tests\Builders\PropertyBuilderTest::it_will_build_the_property_according_to_specific_rules";d:0;s:108:"Spatie\IcalendarGenerator\Tests\Builders\PropertyBuilderTest::it_will_use_the_alias_of_a_property_when_given";d:0;s:74:"Spatie\IcalendarGenerator\Tests\ComponentPayloadTest::a_payload_has_a_type";d:0;s:83:"Spatie\IcalendarGenerator\Tests\ComponentPayloadTest::a_payload_includes_properties";d:0.001;s:87:"Spatie\IcalendarGenerator\Tests\ComponentPayloadTest::a_payload_includes_sub_components";d:0;s:93:"Spatie\IcalendarGenerator\Tests\ComponentPayloadTest::a_payload_can_give_a_specified_property";d:0;s:113:"Spatie\IcalendarGenerator\Tests\ComponentPayloadTest::an_exception_will_be_thrown_when_an_property_does_not_exist";d:0.001;s:109:"Spatie\IcalendarGenerator\Tests\ComponentPayloadTest::a_when_will_only_be_executed_when_the_condition_is_true";d:0;s:93:"Spatie\IcalendarGenerator\Tests\ComponentPayloadTest::a_property_can_be_added_with_parameters";d:0;s:79:"Spatie\IcalendarGenerator\Tests\ComponentPayloadTest::a_property_can_be_aliased";d:0;s:86:"Spatie\IcalendarGenerator\Tests\Components\AlertTest::it_can_create_an_alert_at_a_date";d:0.001;s:101:"Spatie\IcalendarGenerator\Tests\Components\AlertTest::it_can_create_an_alert_at_the_start_of_an_event";d:0;s:99:"Spatie\IcalendarGenerator\Tests\Components\AlertTest::it_can_create_an_alert_at_the_end_of_an_event";d:0;s:101:"Spatie\IcalendarGenerator\Tests\Components\AlertTest::it_can_be_constructed_as_static_before_or_after";d:0;s:81:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::it_can_create_a_calendar";d:0.001;s:87:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::it_can_set_calendar_properties";d:0;s:90:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::it_can_add_an_event_to_a_calendar";d:0;s:101:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::it_can_add_an_event_by_closure_to_a_calendar";d:0;s:97:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::it_can_add_multiple_events_to_a_calendar";d:0;s:108:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::it_can_add_multiple_events_by_closure_to_a_calendar";d:0;s:120:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::when_setting_with_timezones_events_will_be_added_with_timezones";d:0;s:82:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::a_refresh_rate_can_be_set";d:0;s:94:"Spatie\IcalendarGenerator\Tests\Components\CalendarTest::it_is_possible_to_add_multiple_events";d:0;s:106:"Spatie\IcalendarGenerator\Tests\Components\ComponentTest::it_will_check_if_all_required_properties_are_set";d:0.002;s:120:"Spatie\IcalendarGenerator\Tests\Components\ComponentTest::it_will_throw_an_exception_when_a_required_property_is_not_set";d:0.002;s:135:"Spatie\IcalendarGenerator\Tests\Components\ComponentTest::it_will_throw_an_exception_when_a_required_property_is_not_set_but_another_is";d:0.001;s:86:"Spatie\IcalendarGenerator\Tests\Components\ComponentTest::it_can_add_an_extra_property";d:0;s:91:"Spatie\IcalendarGenerator\Tests\Components\ComponentTest::it_can_add_an_extra_sub_component";d:0;s:76:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_create_an_event";d:0.001;s:87:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_set_properties_on_an_event";d:0;s:85:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_set_a_period_on_an_event";d:0;s:80:"Spatie\IcalendarGenerator\Tests\Components\EventTest::an_event_can_be_a_full_day";d:0;s:90:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_alert_minutes_before_an_event";d:0.001;s:89:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_alert_minutes_after_an_event";d:0;s:73:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_add_an_alert";d:0;s:80:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_set_the_coordinates";d:0.001;s:98:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_generate_an_apple_structured_location";d:0;s:81:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_add_a_classification";d:0.002;s:86:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_make_an_event_transparent";d:0;s:77:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_add_an_organizer";d:0.001;s:74:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_add_attendees";d:0.001;s:73:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_set_a_status";d:0.001;s:73:"Spatie\IcalendarGenerator\Tests\IntegrationTest::it_can_create_a_calendar";d:0;s:117:"Spatie\IcalendarGenerator\Tests\PropertyTypes\CalendarAddressPropertyTypeTest::it_can_create_a_calendar_property_type";d:0;s:121:"Spatie\IcalendarGenerator\Tests\PropertyTypes\CalendarAddressPropertyTypeTest::it_can_set_a_name_and_participation_status";d:0;s:116:"Spatie\IcalendarGenerator\Tests\PropertyTypes\CoordinatesPropertyTypeTest::it_can_create_a_coordinates_property_type";d:0;s:105:"Spatie\IcalendarGenerator\Tests\PropertyTypes\DateTimePropertyTypeTest::it_will_format_the_date_correctly";d:0;s:114:"Spatie\IcalendarGenerator\Tests\PropertyTypes\DateTimePropertyTypeTest::it_will_format_the_date_and_time_correctly";d:0;s:127:"Spatie\IcalendarGenerator\Tests\PropertyTypes\DateTimePropertyTypeTest::it_will_format_the_date_and_time_and_timezone_correctly";d:0;s:110:"Spatie\IcalendarGenerator\Tests\PropertyTypes\DurationPropertyTypeTest::it_can_create_a_duration_property_type";d:0;s:110:"Spatie\IcalendarGenerator\Tests\PropertyTypes\DurationPropertyTypeTest::it_can_invert_a_duration_property_type";d:0;s:125:"Spatie\IcalendarGenerator\Tests\PropertyTypes\DurationPropertyTypeTest::it_can_create_a_duration_property_with_all_properties";d:0;s:95:"Spatie\IcalendarGenerator\Tests\PropertyTypes\ParameterTest::it_replaces_all_illegal_characters";d:0;s:84:"Spatie\IcalendarGenerator\Tests\PropertyTypes\ParameterTest::it_can_disable_escaping";d:0;s:105:"Spatie\IcalendarGenerator\Tests\PropertyTypes\PropertyTypeTest::a_property_can_give_a_specified_parameter";d:0;s:124:"Spatie\IcalendarGenerator\Tests\PropertyTypes\PropertyTypeTest::an_exception_will_be_thrown_when_an_parameter_does_not_exist";d:0;s:102:"Spatie\IcalendarGenerator\Tests\PropertyTypes\TextPropertyTypeTest::it_replaces_all_illegal_characters";d:0;s:91:"Spatie\IcalendarGenerator\Tests\PropertyTypes\TextPropertyTypeTest::it_can_disable_escaping";d:0;s:88:"Spatie\IcalendarGenerator\Tests\Components\EventTest::it_can_set_an_address_without_name";d:0;}}}

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to `icalendar-generator` will be documented in this file
 
+## 1.0.3 - 2020-04-29
+
+- fix addresses not working without the name of the address
+
 ## 1.0.2 - 2020-03-27
 
 - add escaping in property parameters (#17)

src/Components/Event.php

@@ -280,7 +280,7 @@ private function resolveLocationProperties(ComponentPayload $payload): Component
 
         $payload->property(CoordinatesPropertyType::create('GEO', $this->lat, $this->lng));
 
-        if (is_null($this->address)) {
+        if (is_null($this->address) || is_null($this->addressName)) {
             return $payload;
         }
 

tests/Components/EventTest.php

@@ -236,4 +236,19 @@ public function it_can_set_a_status()
             $payload
         );
     }
+
+    /** @test */
+    public function it_can_set_an_address_without_name()
+    {
+        $dateStarts = new DateTime('17 may 2019');
+        $dateEnds = new DateTime('18 may 2019');
+
+        $payload = Event::create('An introduction into event sourcing')
+            ->startsAt($dateStarts)
+            ->endsAt($dateEnds)
+            ->address('Antwerp')
+            ->resolvePayload();
+
+        $this->assertPropertyEqualsInPayload('LOCATION', 'Antwerp', $payload);
+    }
 }