Validate Register účtovných závierok API responses with nette/schema

Similar to how it's done with ARES.

Author: spaze

app/psalm-baseline.xml

@@ -1,15 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
-  <file src="src/CompanyInfo/CompanyRegisterRegisterUz.php">
-    <MixedArgument>
-      <code><![CDATA[$unit->ico]]></code>
-      <code><![CDATA[$unit->mesto]]></code>
-      <code><![CDATA[$unit->nazovUJ]]></code>
-      <code><![CDATA[$unit->psc]]></code>
-      <code><![CDATA[$unit->ulica]]></code>
-      <code><![CDATA[$units->id]]></code>
-    </MixedArgument>
-  </file>
   <file src="src/EasterEgg/WinterIsComing.php">
     <MixedArgument>
       <code><![CDATA[$input->getValue()]]></code>

app/src/CompanyInfo/CompanyRegisterRegisterUz.php

@@ -9,6 +9,10 @@
 use MichalSpacekCz\Http\Client\HttpClientRequest;
 use MichalSpacekCz\Http\Exceptions\HttpClientRequestException;
 use Nette\Http\IResponse;
+use Nette\Schema\Elements\Structure;
+use Nette\Schema\Expect;
+use Nette\Schema\Processor;
+use Nette\Schema\ValidationException;
 use Nette\Utils\Json;
 use Nette\Utils\JsonException;
 use Override;
@@ -28,6 +32,7 @@
 
 
 	public function __construct(
+		private Processor $schemaProcessor,
 		private HttpClient $httpClient,
 	) {
 	}
@@ -54,25 +59,54 @@ public function getDetails(string $companyId): CompanyInfoDetails
 		if (empty($units->id)) {
 			throw new CompanyNotFoundException();
 		}
-		$unit = $this->call('uctovna-jednotka', ['id' => reset($units->id)]);
-
+		try {
+			/** @var Structure $expectArray */
+			$expectArray = $this->schemaProcessor->process(
+				Expect::type(Structure::class),
+				Expect::array([
+					Expect::int()->required(),
+				]),
+			);
+			$schema = Expect::structure([
+				'id' => $expectArray->otherItems()->required(),
+			])->otherItems();
+			/** @var object{id:array{0:int}} $data */
+			$data = $this->schemaProcessor->process($schema, $units);
+		} catch (ValidationException $e) {
+			throw new CompanyInfoException($e->getMessage(), previous: $e);
+		}
+		$unit = $this->call('uctovna-jednotka', ['id' => $data->id[0]]);
+		try {
+			$schema = Expect::structure([
+				'ico' => Expect::string()->required(),
+				'dic' => Expect::string(),
+				'nazovUJ' => Expect::string()->required(),
+				'ulica' => Expect::string()->required(),
+				'mesto' => Expect::string()->required(),
+				'psc' => Expect::string()->required(),
+			])->otherItems();
+			/** @var object{ico:string, dic?:string, nazovUJ:string, ulica:string, mesto:string, psc:string} $data */
+			$data = $this->schemaProcessor->process($schema, $unit);
+		} catch (ValidationException $e) {
+			throw new CompanyInfoException($e->getMessage(), previous: $e);
+		}
 		return new CompanyInfoDetails(
 			IResponse::S200_OK,
 			'OK',
-			$unit->ico,
-			isset($unit->dic) && is_string($unit->dic) ? strtoupper(self::COUNTRY_CODE) . $unit->dic : '',
-			$unit->nazovUJ,
-			$unit->ulica,
-			$unit->mesto,
-			$unit->psc,
+			$data->ico,
+			isset($data->dic) ? strtoupper(self::COUNTRY_CODE) . $data->dic : '',
+			$data->nazovUJ,
+			$data->ulica,
+			$data->mesto,
+			$data->psc,
 			self::COUNTRY_CODE,
 		);
 	}
 
 
 	/**
 	 * @param string $method
-	 * @param array<string, string> $parameters
+	 * @param array<string, string|int> $parameters
 	 * @return stdClass JSON object
 	 * @throws CompanyInfoException
 	 */

app/tests/CompanyInfo/CompanyRegisterRegisterUzTest.phpt

@@ -7,6 +7,7 @@ namespace MichalSpacekCz\CompanyInfo;
 use MichalSpacekCz\CompanyInfo\Exceptions\CompanyNotFoundException;
 use MichalSpacekCz\Http\Client\HttpClient;
 use MichalSpacekCz\Test\TestCaseRunner;
+use Nette\Schema\Processor;
 use Tester\Assert;
 use Tester\TestCase;
 
@@ -19,9 +20,11 @@ class CompanyRegisterRegisterUzTest extends TestCase
 	private readonly CompanyRegisterRegisterUz $registerUz;
 
 
-	public function __construct()
-	{
-		$this->registerUz = new CompanyRegisterRegisterUz(new HttpClient());
+	public function __construct(
+		Processor $schemaProcessor,
+	) {
+		// Need a real HttpClient, not the mock one used in other tests
+		$this->registerUz = new CompanyRegisterRegisterUz($schemaProcessor, new HttpClient());
 	}