Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanning alert - regex replaces value just once #319

Closed
2 tasks done
spaze opened this issue May 8, 2024 · 1 comment · Fixed by #320
Closed
2 tasks done

Scanning alert - regex replaces value just once #319

spaze opened this issue May 8, 2024 · 1 comment · Fixed by #320
Assignees
@spaze

Comments

@spaze
Copy link
Owner

spaze commented May 8, 2024 •
edited
Loading

This replaces only the first occurrence of '\r'.

michalspacek.cz/site/vendor/nette/forms/src/assets/netteForms.js

Line 111 in abdf40e

return elem.value.replace('\r', '').replace(/^\s+|\s+$/g, '');

Tracking issue for:
@spaze spaze self-assigned this May 8, 2024
@spaze
Copy link
Owner Author

spaze commented May 8, 2024 •
edited
Loading

Will be resolved by #320 which updates nette/forms to 3.2.3 which modernized code (their words, not mine) which removes the replace call.

spaze added a commit that referenced this issue May 8, 2024
@spaze
Update package nette/forms
6a77136 
 - nette/forms updated from v3.2.2 to v3.2.3 patch
   See changes: nette/forms@v3.2.2...v3.2.3
   Release notes: https://github.com/nette/forms/releases/tag/v3.2.3

Replace #317
Close #319
@spaze spaze mentioned this issue May 8, 2024
Merged
@spaze spaze closed this as completed in #320 May 8, 2024
spaze added a commit that referenced this issue May 8, 2024
@spaze
Update package nette/forms (#320)
b0ec2cd 
 - nette/forms updated from v3.2.2 to v3.2.3 patch
   See changes: nette/forms@v3.2.2...v3.2.3
   Release notes: https://github.com/nette/forms/releases/tag/v3.2.3

Replace #317
Close #319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spaze spaze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update package nette/forms spaze/michalspacek.cz
1 participant
@spaze