Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DebuggerDisplay] attribute on Paragraph is broken #1476

Closed
martincostello opened this issue Feb 22, 2024 · 1 comment · Fixed by #1477
Closed

[DebuggerDisplay] attribute on Paragraph is broken #1476

martincostello opened this issue Feb 22, 2024 · 1 comment · Fixed by #1477
Labels
bug Something isn't working needs triage
Milestone

Comments

@martincostello
Copy link
Contributor

Information

  • OS: N/A
  • Version: 0.48.0
  • Terminal: N/A

Describe the bug

The [DebuggerDisplay] attribute on Paragraph references a field that no longer exists:

[DebuggerDisplay("{_text,nq}")]
public sealed class Paragraph : Renderable, IHasJustification, IOverflowable

This causes an error message to be rendered in a debugger if inspecting a Paragraph instance.

To Reproduce

View an instance of Paragraph in a debugger such as Visual Studio.

Expected behavior

No error is shown.

Screenshots

image

@martincostello
Copy link
Contributor Author

Opened #1477 to remove the attribute as there appears to be no member that is a trivial equivalent.

@github-project-automation github-project-automation bot moved this from Todo 🕑 to Done 🚀 in Spectre Console Feb 23, 2024
@patriksvensson patriksvensson added this to the 0.49 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

2 participants