Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search doesn't work properly in selection prompts #1536

Open
just-a-hriday opened this issue May 2, 2024 · 2 comments · May be fixed by #1601
Open

Search doesn't work properly in selection prompts #1536

just-a-hriday opened this issue May 2, 2024 · 2 comments · May be fixed by #1601
Labels
bug Something isn't working needs triage ⭐ top bug Top bug.

Comments

@just-a-hriday
Copy link

just-a-hriday commented May 2, 2024

Information

  • OS: Windows 11
  • Version: 0.49.1
  • Terminal: Windows Terminal

Describe the bug

Clicking space while searching in a selection prompt stops the search and instead selects an option.

To Reproduce

On a selection prompt with search enabled, search for something with a space in it. As soon as you click space, the option you are currently on will get selected and the search will stop.

Expected behavior

Space shouldn't select an option on a prompt with search enabled.


Please upvote 👍 this issue if you are interested in it.

@Mystler
Copy link

Mystler commented May 2, 2024

I can confirm this. Should only affect regular selection prompts since i think multi-selection ones don't support search, at the moment.

@just-a-hriday just-a-hriday changed the title Search doesn't work properly in selection/multi-selection prompts Search doesn't work properly in selection prompts May 2, 2024
@github-actions github-actions bot added the ⭐ top bug Top bug. label May 3, 2024
@DerReparator
Copy link

I can confirm this. Should only affect regular selection prompts since i think multi-selection ones don't support search, at the moment.

We had this exact behavior at work today. I would try and submit a PR containing a change such that the regular selection prompt searches for Space instead of selecting the current choice iff search is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage ⭐ top bug Top bug.
Projects
Status: Todo 🕑
Development

Successfully merging a pull request may close this issue.

3 participants