port = 0 is allowed

chetan-spheron · chetan-spheron · commit 9ce29172d04a · 2024-10-15T16:17:50.000+05:30
diff --git a/go/manifest/v2beta2/serviceexpose.go b/go/manifest/v2beta2/serviceexpose.go
@@ -41,7 +41,8 @@ func (s *ServiceExpose) GetEndpoints() types.Endpoints {
 }
 
 func (s *ServiceExpose) validate(helper *validateManifestGroupsHelper) error {
-	if s.Port == 0 || s.Port > math.MaxUint16 {
+	// make port optional port = 0 is allowed
+	if s.Port > math.MaxUint16 {
 		return fmt.Errorf("port value must be 0 < value <= 65535 ")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,8 @@ func (s *ServiceExpose) GetEndpoints() types.Endpoints {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`func (s ServiceExpose) validate(helper validateManifestGroupsHelper) error {`
`44`		`- if s.Port == 0 \|\| s.Port > math.MaxUint16 {`
	`44`	`+ // make port optional port = 0 is allowed`
	`45`	`+ if s.Port > math.MaxUint16 {`
`45`	`46`	`return fmt.Errorf("port value must be 0 < value <= 65535 ")`
`46`	`47`	`}`
`47`	`48`