Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable-length arrays are not compatible with MSVC #20

Closed
thomwiggers opened this issue Mar 12, 2021 · 1 comment · Fixed by #26
Closed

Variable-length arrays are not compatible with MSVC #20

thomwiggers opened this issue Mar 12, 2021 · 1 comment · Fixed by #26

Comments

@thomwiggers
Copy link
Contributor

In the category "Microsoft compilers suck", such as previously seen in #14, the use of variable-length arrays is not supported by Microsoft compilers. This means even the ref implementation doesn't work on Windows.
@thomwiggers
Copy link
Contributor Author

As used in e.g. https://github.com/thomwiggers/sphincsplus/blob/master/ref/thash_haraka_robust.c#L16-L17

@thomwiggers thomwiggers mentioned this issue Mar 12, 2021
Open
bwesterb added a commit that referenced this issue Dec 29, 2021
@bwesterb
For MSVC use alloca() instead of VLA
3f56890 
Closes #20
@bwesterb bwesterb mentioned this issue Dec 29, 2021
Merged
bwesterb added a commit that referenced this issue Aug 2, 2022
@bwesterb
For MSVC use alloca() instead of VLA
15f872c 
Closes #20
bwesterb added a commit that referenced this issue Aug 2, 2022
@bwesterb @thomwiggers
For MSVC use alloca() instead of VLA
5382a43 
Closes #20

Co-authored-by: Thom Wiggers <thom@thomwiggers.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For MSVC use alloca() instead of VLA sphincs/sphincsplus
1 participant
@thomwiggers