Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboardShortcut.js: pressing / to search no longer works #3200

Closed
2 tasks done
rien333 opened this issue Oct 12, 2024 · 2 comments
Closed
2 tasks done

keyboardShortcut.js: pressing / to search no longer works #3200

rien333 opened this issue Oct 12, 2024 · 2 comments
Labels
πŸ› bug Something isn't working

Comments

@rien333
Copy link

rien333 commented Oct 12, 2024

πŸ” Have you checked Spicetify.app page for your issue?

  • I have checked the FAQ

πŸ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

β„Ή Environment / Computer Info

- Spotify version: 1.2.47.364.gf06e5cee
- Spicetify version: 2.38.4
- OS: Arch Linux

πŸ“ Description

Extensions/keyboardShortcut.js provides / as a search key, as in vim.

However, somewhat recently (probably during the 1.2.47 update, which revamped the search bar), this shortcut key has stopped working.

More specifically, spotify goes into "searching mode", but the search bar itself remains unfocused.

πŸ“Έ Screenshots

No response

@rien333 rien333 added the πŸ› bug Something isn't working label Oct 12, 2024
@rien333 rien333 changed the title keyboardShortcut.js: pressing <kbd>/</kbd> to search no longer works keyboardShortcut.js: pressing / to search no longer works Oct 12, 2024
@rien333 rien333 mentioned this issue Oct 12, 2024
2 tasks
@rxri
Copy link
Member

rxri commented Nov 2, 2024

/ shortcut only redirects to /search. If it did focus search bar, then it was on spotify side and not ours.

https://github.com/spicetify/cli/blob/main/Extensions/keyboardShortcut.js#L55

@rxri rxri closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2024
@rien333
Copy link
Author

rien333 commented Nov 3, 2024

/ shortcut only redirects to /search

This is a good technical explanation of why this issue occurs, but misses the intent behind this bug report and/or the extension.
The intended behavior of the / bind is β€” and always has been β€” to match the functionality of the built-in Ctrl-L shortcut. That it now simply redirects to /search is an implementation-level detail, without any special significance β€” / has not always been a simple redirector. This current implementation worked for a while, but now it no longer does.

Of course, closing this because of a lack of interest is perfectly valid, but at that point I feel like extensions should be maintained out of tree (which I feel like is in the works?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants