Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgroup => true problematic with rerun use #9

Open
dentarg opened this issue Feb 13, 2025 · 0 comments
Open

pgroup => true problematic with rerun use #9

dentarg opened this issue Feb 13, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@dentarg
Copy link
Member

dentarg commented Feb 13, 2025

#1 added the pgroup => true option to Process.spawn

def run(options={})
env = @options[:env].merge(options[:env] || {})
output = options[:output] || $stdout
runner = "#{Foreman.runner}".shellescape
pgroup = Foreman.windows? ? :new_pgroup : :pgroup
Dir.chdir(cwd) do
Process.spawn env, expanded_command(env), :out => output, :err => output, pgroup => true
end
end

That makes this chain stop working: overman -> rerun -> overman -> <app>

rerun prints [rerun] <app> launched but it is never started

Not sure if it depends on what flags you pass to rerun, I should post a repro here. I've been using rerun 0.14.0.

@dentarg dentarg added the bug Something isn't working label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant