Skip to content

Commit c4d1827

Browse files
authored
Revert "feat(kubectl): Extract interface for KubectlJobExecutor and use it. (#6076)" (#6092)
This reverts commit bb04878.
1 parent c90e3e3 commit c4d1827

File tree

14 files changed

+1245
-1390
lines changed

14 files changed

+1245
-1390
lines changed

clouddriver-kubernetes/src/main/java/com/netflix/spinnaker/clouddriver/kubernetes/caching/agent/KubernetesCachingAgent.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import com.netflix.spinnaker.clouddriver.kubernetes.description.manifest.KubernetesKindProperties.ResourceScope;
4242
import com.netflix.spinnaker.clouddriver.kubernetes.description.manifest.KubernetesManifest;
4343
import com.netflix.spinnaker.clouddriver.kubernetes.description.manifest.KubernetesManifestAnnotater;
44+
import com.netflix.spinnaker.clouddriver.kubernetes.op.job.KubectlJobExecutor;
4445
import com.netflix.spinnaker.clouddriver.kubernetes.security.KubernetesCredentials;
4546
import com.netflix.spinnaker.clouddriver.kubernetes.security.KubernetesNamedAccountCredentials;
4647
import java.util.Arrays;
@@ -84,6 +85,7 @@ public abstract class KubernetesCachingAgent
8485

8586
protected final int agentIndex;
8687
protected final int agentCount;
88+
protected KubectlJobExecutor jobExecutor;
8789

8890
@Getter protected String providerName = KubernetesCloudProvider.ID;
8991

clouddriver-kubernetes/src/main/java/com/netflix/spinnaker/clouddriver/kubernetes/caching/view/provider/KubernetesInstanceProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import com.netflix.spinnaker.clouddriver.kubernetes.caching.view.model.KubernetesInstance;
2424
import com.netflix.spinnaker.clouddriver.kubernetes.description.KubernetesCoordinates;
2525
import com.netflix.spinnaker.clouddriver.kubernetes.model.ContainerLog;
26-
import com.netflix.spinnaker.clouddriver.kubernetes.op.job.DefaultKubectlJobExecutor;
26+
import com.netflix.spinnaker.clouddriver.kubernetes.op.job.KubectlJobExecutor;
2727
import com.netflix.spinnaker.clouddriver.kubernetes.security.KubernetesCredentials;
2828
import com.netflix.spinnaker.clouddriver.model.InstanceProvider;
2929
import io.kubernetes.client.openapi.models.V1Container;
@@ -119,7 +119,7 @@ private ContainerLog getContainerLog(
119119
String containerLogs =
120120
credentials.logs(metadata.getNamespace(), metadata.getName(), containerName);
121121
return new ContainerLog(containerName, containerLogs);
122-
} catch (DefaultKubectlJobExecutor.KubectlException e) {
122+
} catch (KubectlJobExecutor.KubectlException e) {
123123
// Typically happens if the container/pod isn't running yet
124124
return new ContainerLog(containerName, e.getMessage());
125125
}

clouddriver-kubernetes/src/main/java/com/netflix/spinnaker/clouddriver/kubernetes/op/handler/CanDeploy.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import com.netflix.spinnaker.clouddriver.kubernetes.description.manifest.KubernetesManifest;
2222
import com.netflix.spinnaker.clouddriver.kubernetes.description.manifest.KubernetesManifestStrategy;
2323
import com.netflix.spinnaker.clouddriver.kubernetes.op.OperationResult;
24-
import com.netflix.spinnaker.clouddriver.kubernetes.op.job.DefaultKubectlJobExecutor;
24+
import com.netflix.spinnaker.clouddriver.kubernetes.op.job.KubectlJobExecutor;
2525
import com.netflix.spinnaker.clouddriver.kubernetes.security.KubernetesCredentials;
2626
import com.netflix.spinnaker.clouddriver.kubernetes.security.KubernetesSelectorList;
2727
import io.kubernetes.client.openapi.models.V1DeleteOptions;
@@ -52,7 +52,7 @@ default OperationResult deploy(
5252
new V1DeleteOptions(),
5353
task,
5454
opName);
55-
} catch (DefaultKubectlJobExecutor.KubectlException ignored) {
55+
} catch (KubectlJobExecutor.KubectlException ignored) {
5656
}
5757
deployedManifest = credentials.deploy(manifest, task, opName);
5858
break;

0 commit comments

Comments
 (0)