Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since PHP 7.4 base_convert will show a deprecation warning #4

Open
jonathanbossenger opened this issue Nov 14, 2021 · 0 comments · May be fixed by #5
Open

Since PHP 7.4 base_convert will show a deprecation warning #4

jonathanbossenger opened this issue Nov 14, 2021 · 0 comments · May be fixed by #5

Comments

@jonathanbossenger
Copy link

In the up.php file on line 147 and 151 base_convert( uniqid( 'pass', true ), 10, 20 ) is used

From the base_convert changelog:

Passing invalid characters will now generate a deprecation notice. The result will still be computed as if the invalid characters did not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the up function to use the new generate_password function spinupwp/wp-cli-up
1 participant
@jonathanbossenger