From 53d35dff0ae682c52f1268ef49c736d22f0dcbc0 Mon Sep 17 00:00:00 2001 From: Ryan Bottriell Date: Wed, 13 Dec 2023 09:10:38 -0800 Subject: [PATCH] Remove spfs-join from process tree Our users reported some unexpected behaviour, like spfs-join capturing ctrl-c and breaking interactions with launched processes. Signed-off-by: Ryan Bottriell --- crates/spfs-cli/cmd-join/src/cmd_join.rs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/crates/spfs-cli/cmd-join/src/cmd_join.rs b/crates/spfs-cli/cmd-join/src/cmd_join.rs index 439c57b75..f26485052 100644 --- a/crates/spfs-cli/cmd-join/src/cmd_join.rs +++ b/crates/spfs-cli/cmd-join/src/cmd_join.rs @@ -129,12 +129,9 @@ impl CmdJoin { spfs::build_interactive_shell_command(rt, None)? } }; - let mut proc = cmd.into_std(); - tracing::debug!("{:?}", proc); - Ok(proc - .status() - .map_err(|err| Error::process_spawn_error("exec_runtime_command", err, None))? - .code() - .unwrap_or(1)) + tracing::debug!("{cmd:?}"); + cmd.exec() + .map(|_| 0) + .wrap_err("Failed to execute runtime command") } }