From e03d04d476f99fcf4ff98c0c67dfab0267b617bf Mon Sep 17 00:00:00 2001 From: Nichol Yip Date: Mon, 26 Aug 2024 17:09:51 -0700 Subject: [PATCH] Fix conflicts from rebase --- crates/spk-schema/src/metadata/meta.rs | 4 ++-- crates/spk-schema/src/spec.rs | 9 ++------- crates/spk-schema/src/v0/mod.rs | 1 - crates/spk-schema/src/v0/spec.rs | 1 - crates/spk-schema/src/v0/test_spec.rs | 1 - 5 files changed, 4 insertions(+), 12 deletions(-) diff --git a/crates/spk-schema/src/metadata/meta.rs b/crates/spk-schema/src/metadata/meta.rs index 791d958525..7322b189d3 100644 --- a/crates/spk-schema/src/metadata/meta.rs +++ b/crates/spk-schema/src/metadata/meta.rs @@ -16,7 +16,7 @@ use crate::{Error, Lint, LintedItem, Lints, Result, UnknownKey}; #[path = "./meta_test.rs"] mod meta_test; -#[derive(Clone, Debug, Eq, Hash, Ord, PartialEq, PartialOrd, Serialize)] +#[derive(Default, Clone, Debug, Eq, Hash, Ord, PartialEq, PartialOrd, Serialize)] pub struct Meta { #[serde(default, skip_serializing_if = "Option::is_none")] pub description: Option, @@ -107,7 +107,7 @@ impl From for Meta { Self { description: value.description, homepage: value.homepage, - license: value.license.unwrap_or(Meta::default_license()), + license: value.license, labels: value.labels.unwrap_or_default(), } } diff --git a/crates/spk-schema/src/spec.rs b/crates/spk-schema/src/spec.rs index afd703e34e..46c672bf95 100644 --- a/crates/spk-schema/src/spec.rs +++ b/crates/spk-schema/src/spec.rs @@ -162,13 +162,8 @@ impl Template for SpecTemplate { fn render_to_string(&self, options: &OptionMap) -> Result { let data = super::TemplateData::new(options); - let rendered = spk_schema_tera::render_template( - self.file_path.to_string_lossy(), - &self.template, - &data, - ) - .map_err(Error::InvalidTemplate)?; - Ok(SpecRecipe::from_yaml(rendered)?) + spk_schema_tera::render_template(self.file_path.to_string_lossy(), &self.template, &data) + .map_err(Error::InvalidTemplate) } } diff --git a/crates/spk-schema/src/v0/mod.rs b/crates/spk-schema/src/v0/mod.rs index 6eb8acc833..ba52ff8e45 100644 --- a/crates/spk-schema/src/v0/mod.rs +++ b/crates/spk-schema/src/v0/mod.rs @@ -10,7 +10,6 @@ mod variant_spec; pub use platform::Platform; pub use spec::Spec; -pub use spec::{LintedSpec, Spec}; pub use test_spec::TestSpec; pub use variant::Variant; pub use variant_spec::VariantSpec; diff --git a/crates/spk-schema/src/v0/spec.rs b/crates/spk-schema/src/v0/spec.rs index 76ef1d21a5..4f4682b11b 100644 --- a/crates/spk-schema/src/v0/spec.rs +++ b/crates/spk-schema/src/v0/spec.rs @@ -14,7 +14,6 @@ use spk_schema_foundation::ident_build::BuildId; use spk_schema_foundation::ident_component::ComponentBTreeSet; use spk_schema_foundation::option_map::{OptFilter, Stringified}; use spk_schema_foundation::version::IncompatibleReason; -use spk_schema_foundation::option_map::Stringified; use spk_schema_ident::{AnyIdent, BuildIdent, Ident, RangeIdent, VersionIdent}; use struct_field_names_as_array::FieldNamesAsArray; diff --git a/crates/spk-schema/src/v0/test_spec.rs b/crates/spk-schema/src/v0/test_spec.rs index 36f1e97b43..8650261127 100644 --- a/crates/spk-schema/src/v0/test_spec.rs +++ b/crates/spk-schema/src/v0/test_spec.rs @@ -2,7 +2,6 @@ // SPDX-License-Identifier: Apache-2.0 // https://github.com/spkenv/spk -use ngrammatic::CorpusBuilder; use serde::{Deserialize, Serialize}; use spk_schema_foundation::option_map::Stringified; use struct_field_names_as_array::FieldNamesAsArray;