Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spfs clean doesn't clean renders it cases it should be able to #1145

Open
jrray opened this issue Nov 6, 2024 · 1 comment
Open

spfs clean doesn't clean renders it cases it should be able to #1145

jrray opened this issue Nov 6, 2024 · 1 comment
Labels
accepted An issue or feature request that should be developed

Comments

@jrray
Copy link
Collaborator

jrray commented Nov 6, 2024

A situation has developed here where workstations are being used for overnight rendering but workstations are not configured to use spfs-fuse. Therefore workstations create spfs runtime for various users overnight, creating local renders for each user in the local spfs repo. By morning these jobs easily fill up the local disk.

Then, spfs clean during the day is only able to reclaim a small amount of space, depending on what the daytime user is doing on the workstation. In one case, there are three active runtimes, holding strong references to a number of spfs objects (payloads). These payloads exist in renders for numerous users (55). Although the only active runtimes on the workstation are from user A, renders for users B, C, ..., are not deleted.

It should be possible to also consider if user-specific renders are in use, and clean up renders for users that do not have any active runtimes.

@jrray jrray added the agenda item Items to be brought up at the next dev meeting label Nov 6, 2024
@rydrman
Copy link
Collaborator

rydrman commented Nov 6, 2024

From the meeting today:

  • can be done fairly easily as a separate stage in the spfs clean command by loading the active runtimes for each user, getting the layers that are used and then removing renders for that user that are not part of active runtimes anymore
  • could break if someone is about to create a runtime (related to solutions from [RFC] SPFS Safe Deletion #1011)

@rydrman rydrman added accepted An issue or feature request that should be developed and removed agenda item Items to be brought up at the next dev meeting labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An issue or feature request that should be developed
Projects
None yet
Development

No branches or pull requests

2 participants