Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warmup.cfg not executed after .forceend #246

Open
borzaka opened this issue Oct 17, 2018 · 5 comments
Open

warmup.cfg not executed after .forceend #246

borzaka opened this issue Oct 17, 2018 · 5 comments

Comments

@borzaka
Copy link
Contributor

borzaka commented Oct 17, 2018

Expected behavior

warmup.cfg should execute after game finish.

Actual behavior

With forceend (and probably with .endgame) it's not executed.

Steps to reproduce

  • Plugin version: 2.0.5
  • Sourcemod version: 1.9.0.6260
  1. start a game
  2. end with forceeend or endgame
@splewis
Copy link
Owner

splewis commented Oct 18, 2018

I don't think the warmup config should be executed then, at least not by default.

A reasonable alternative behavior would be to revert all cvars pugsetup has changed - but I think the current behavior is okay with me.

@borzaka
Copy link
Contributor Author

borzaka commented Oct 18, 2018

Sorry, I don't agree. :)

  • If you join to a pug-setup enabled server, you will end up in a warmup mode, until everyone is ready, or a new game setup finishes.
  • If the match is finished, the server goes to warmup mode again.
  • But if you forceend a match, you will end up in something different: something close to a live match; default rounds, default money, etc. Whats the point of this? And after a couple of round, you will have max money, but it's not actually a warmup mode - you have to wait until one team dies.

I think a warmup mode should be the "limbo", where everybody just waits to start a match, and can play freely with max money, etc.

From the config:

// Config file to run before/after games; should be in the csgo/cfg directory.
// -
// Default: "sourcemod/pugsetup/warmup.cfg"
sm_pugsetup_warmup_cfg "sourcemod/pugsetup/warmup.cfg"

.forceend is "after games".

I'am using:

  • sm_pugsetup_autosetup "1"
  • sm_pugsetup_force_defaults "1"

My suggestion:
If sm_pugsetup_force_defaults is 1, .forceend should end and start a new setup and a warmup would begin.

@shayota
Copy link

shayota commented Jun 12, 2019

If I may add a comment I'd like to get a response. I'm currently experiencing something similar.

Background Info:
I have a ranking plugin on the server and that plugin's cvar for gathering statistics is not working so I've gone ahead and setup my cfg's so that no matter what the session is always in warmup when it's not live and the ranking plugin does not keep score.

Issue At Hand:
Now the issue I'm experiencing is a bit more niche. When I use .endgame during a live match, it executes the warmup.cfg that is listed in the pugsetup.cfg and the server will begin warmup mode but when I execute .endgame during the ready up or team picking process, pugsetup seems to enter this weird state sort of like borzaka explained above. Its close to a live match with default rounds but respawns are enabled and during this time the ranking plugin is keeping score.

Question:
So my question is what cfg is the plugin using when .endgame is executed during the readyup/team picking phase? If its the same cfg for postgame (which is warmup.cfg) then why am I getting 2 different results?

When the game is live the plugin handles everything as expected but when the .endgame cmd is executed during the readyup/team picking process, that's when it enters this unknown mode (for lack of a better term)

I would like to edit that cfg so that the server enters the warmup mode instead of entering the "unknown mode".

@splewis
Copy link
Owner

splewis commented Jun 18, 2019

So my question is what cfg is the plugin using when .endgame is executed during the readyup/team picking phase?

I don't know the answer. I'd have to look at the code, and this problem doesn't exist for me so I'm probably never going to.

When the game is live the plugin handles everything as expected but when the .endgame cmd is executed during the readyup/team picking process, that's when it enters this unknown mode (for lack of a better term)

There is no "unknown mode". There's no game setup anymore. That's it. Pugsetup is designed for private servers and to be non-invasive. Telling pugsetup .forceend is a way of saying 'stop doing anything whatsoever', not 'end this game and put the server in X state'. That will not be changed. If you want to totally restart a game, running .endgame and .setup is exactly what is intended.

I have a ranking plugin on the server and that plugin's cvar for gathering statistics is not working so I've gone ahead and setup my cfg's so that no matter what the session is always in warmup when it's not live and the ranking plugin does not keep score.

Pugsetup has a native to get the game state, which it seems like you should be using instead.

@shayota
Copy link

shayota commented Jun 19, 2019

Duly noted and thank you very much for your response Sean, have a wonderful week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants