Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/issues found in testing #31

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fix/issues found in testing #31

merged 2 commits into from
Jul 27, 2023

Conversation

wojtekzyla
Copy link
Collaborator

@wojtekzyla wojtekzyla commented Jul 19, 2023 •
edited
Loading

  • Add warnings when deleting groups or profiles which are configured in the inventory.
  • No frequency configuration for walk profiles.
  • Default number of presented items changed to 20.
  • Save configuration from mongo to values.yaml on host machine after clicking 'Apply change'

@wojtekzyla
fix: add warnings when deleting groups or profiles which are configur…
8a6cb01 
…ed in the inventory. No frequency configuration for walk profiles. Default number of presented items changed to 20.

fix: change message while deleting profiles. Change what is displayed in Frequency column for walk profiles

fix: update tests

fix: remove unnecessary print

fix: improve logging in handle_changes.py, update config_collection in job insted of in CheckIfPreviousJobFailed

fix: fix error in celery job

fix: update request message in apply_changes

fix: typo in return message

fix: fix problem with editing walk profile

fix: refactor files and write config from mongo to yaml files on host machine

fix: change message in error thrown by SaveConfigToFileHandler
@wojtekzyla
fix: save mongo configuration to values.yaml
fb615f6 
fix: change directory for temp files

fix: add test for edited values.yaml file

fix: typos and description of yaml_escape_list function
@wojtekzyla wojtekzyla merged commit 50c6136 into develop Jul 27, 2023
2 checks passed
@wojtekzyla wojtekzyla deleted the fix/issues-found-in-testing branch July 27, 2023 08:47
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.0.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omrozowicz-splunk omrozowicz-splunk omrozowicz-splunk approved these changes

@ajasnosz ajasnosz ajasnosz approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtekzyla @srv-rr-github-token @omrozowicz-splunk @ajasnosz