Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Bluecoat sourcetype to match TA 3.8.1 #2370

Merged
merged 1 commit into from
May 13, 2024

Conversation

mstopa-splunk
Copy link
Contributor

solves #2347

| bluecoat:proxysg:access:kv | Requires version TA 3.6 |
| bluecoat:proxysg:syslog | Requires version TA 3.6 |
| bluecoat:proxysg:access:kv | Requires version TA 3.8.1 |
| bluecoat:proxysg:access:syslog | Requires version TA 3.8.1 |
Copy link
Contributor

@ikheifets-splunk ikheifets-splunk Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understood correctly that add-on maintainers broke backward compatibility (changed sourcetype) starting with 3.8.1 version ? Or it was our bug?

Can we talk with them to understand the reason? Probably they will rollback this change if add-on not very popular :)

If we need to provide new sourcetype, probably good idea will be use some env var like BLUECOAT_NEW_FORMAT=false and will determine that we need assign old or new sourcetype for bluecoat. If will help us to prevent of breaking backward compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good question, 3.8.1 was released in September 2022 and I don't have access to older versions to check if that was changed on the TA side or there was a bug in SC4S

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

especially that bluecoat:proxysg:access:syslog is more consistent with the rest than bluecoat:proxysg:syslog

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstopa-splunk you are right, it's impossible to check, because they deleted previous versions :)

Only 3.8.1 available on Splunkbase :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikheifets-splunk please see how this has been done previously:

https://splunk.github.io/splunk-connect-for-syslog/main/sources/vendor/Dell/sonicwall/

Note:[¶](https://splunk.github.io/splunk-connect-for-syslog/main/sources/vendor/Dell/sonicwall/#note)
The sourcetype has been changed in version 2.35.0 making it compliant with corresponding TA.

the practice seems to be updating the sourcetype and adding the note

@mstopa-splunk mstopa-splunk changed the title Fix: update Bluecoat sourcetype to match TA 3.8.1 fix: update Bluecoat sourcetype to match TA 3.8.1 May 13, 2024
@mstopa-splunk mstopa-splunk changed the base branch from main to develop May 13, 2024 15:25
@mstopa-splunk mstopa-splunk merged commit 9790b58 into develop May 13, 2024
19 checks passed
@mstopa-splunk mstopa-splunk deleted the update_bluecoat_sourcetype branch May 13, 2024 15:25
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants