Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds config checksums to Helm chart to trigger rollout on change #2551

Closed

Conversation

jmriebold
Copy link

@jmriebold jmriebold commented Aug 7, 2024

We're running into issues where, after updating our config in the chart, we then need to manually restart the StatefulSet in order for it to get the changes. This PR adds checksum annotations for all three ConfigMaps to the StatefulSet, such that changing the config in any way will automatically trigger a rollout.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jmriebold
Copy link
Author

I have read the Code of Conduct and I hereby accept the Terms

@jmriebold
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

srv-rr-github-token added a commit to splunk/cla-agreement that referenced this pull request Aug 7, 2024
@rjha-splunk
Copy link
Collaborator

We will validate and merge in next sprint

@jmriebold
Copy link
Author

Hey @rjha-splunk, are you still planning to merge this? Let me know if there's anything else that needs doing with this PR.

@rjha-splunk
Copy link
Collaborator

Apologies for the delay, it will be for sure reviewed this sprint. @ikheifets-splunk please review it.

@jmriebold
Copy link
Author

No problem at all, thank you!

@ikheifets-splunk
Copy link
Contributor

sure, folks I will review on upcoming week, I temporary was super busy on splunk-connect-for-snmp and haven't time on that. But thanks for reminding @jmriebold

@ikheifets-splunk ikheifets-splunk changed the base branch from main to develop September 16, 2024 09:42
@ikheifets-splunk
Copy link
Contributor

ikheifets-splunk commented Sep 16, 2024

@jmriebold I merging your PR in develop branch. After that I will check deployments changes manually, we can release it :)

@mstopa-splunk mstopa-splunk deleted the branch splunk:develop September 18, 2024 14:18
@jmriebold
Copy link
Author

Hey @mstopa-splunk seems like this wasn't actually merged, just closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants