-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds config checksums to Helm chart to trigger rollout on change #2551
Conversation
CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅ |
1a0b2a8
to
a789e3a
Compare
I have read the Code of Conduct and I hereby accept the Terms |
I have read the CLA Document and I hereby sign the CLA |
We will validate and merge in next sprint |
Hey @rjha-splunk, are you still planning to merge this? Let me know if there's anything else that needs doing with this PR. |
Apologies for the delay, it will be for sure reviewed this sprint. @ikheifets-splunk please review it. |
No problem at all, thank you! |
sure, folks I will review on upcoming week, I temporary was super busy on splunk-connect-for-snmp and haven't time on that. But thanks for reminding @jmriebold |
@jmriebold I merging your PR in |
Hey @mstopa-splunk seems like this wasn't actually merged, just closed? |
We're running into issues where, after updating our config in the chart, we then need to manually restart the StatefulSet in order for it to get the changes. This PR adds checksum annotations for all three ConfigMaps to the StatefulSet, such that changing the config in any way will automatically trigger a rollout.