Introduce minimal WireSchema #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decouples human-readable Schema that is in JSON format from WireSchema that is serialized in binary format for efficiency. WireSchema contains only the information that is necessary for wire compatibility checks. Resolves #24 (Note that we still need struct names for checks). Here are byte size comparisons between JSON and WIRE for the Otel/TEF schema with "Metrics" root: ``` JSON: 2976, zstd: 760 WIRE: 115, zstd: 113 ``` The following components were refactored to use WireSchema instead of Schema: - Generated Reader/Writer - Encoder/Decoders - gRPC client/server The Generator continues using JSON Schema as its input, however it now generates a WireSchema to be used in the generated code.
|
Github action shows benchmark differences, but locally I get parity (as expected, since nothing significant in serialization changed). Local results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples human-readable Schema that is in JSON
format from WireSchema that is serialized in binary
format for efficiency. WireSchema contains only the
information that is necessary for wire compatibility
checks.
Resolves #24
(Note that we still need struct names for checks).
Here are byte size comparisons between JSON and WIRE
for the Otel/TEF schema with "Metrics" root:
The following components were refactored to use WireSchema
instead of Schema:
The Generator continues using JSON Schema as its input, however
it now generates a WireSchema to be used in the generated code.