diff --git a/synthetics/resource_browser_check_v2.go b/synthetics/resource_browser_check_v2.go index 28f4655..3794283 100644 --- a/synthetics/resource_browser_check_v2.go +++ b/synthetics/resource_browser_check_v2.go @@ -245,6 +245,14 @@ func resourceBrowserCheckV2() *schema.Resource { Optional: true, Default: false, }, + "wait_for_nav_timeout": { + Type: schema.TypeInt, + Optional: true, + }, + "max_wait_time": { + Type: schema.TypeInt, + Optional: true, + }, "options": { Type: schema.TypeSet, Optional: true, diff --git a/synthetics/resource_browser_check_v2_test.go b/synthetics/resource_browser_check_v2_test.go index ddc46b3..5863bbe 100644 --- a/synthetics/resource_browser_check_v2_test.go +++ b/synthetics/resource_browser_check_v2_test.go @@ -21,11 +21,21 @@ import ( ) const newBrowserCheckV2Config = ` +resource "synthetics_create_variable_v2" "variable_v2_foo" { + provider = synthetics.synthetics + variable { + description = "The most awesome variable. Full of snakes." + value = "barv3v3" + name = "acceptance-variable-terraform-test" + secret = false + } +} + resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { provider = synthetics.synthetics test { active = true - device_id = 1 + device_id = 1 frequency = 5 location_ids = ["aws-us-east-1"] automatic_retries = 1 @@ -41,7 +51,7 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { collect_interactive_metrics = false authentication { username = "batmab" - password = "{{env.beep-var}}" + password = "{{env.acceptance-variable-terraform-test}}" } headers { name = "superstar-machine" @@ -83,7 +93,8 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { selector = "beep" selector_type = "id" type = "enter_value" - value = "{{env.beep-var}}" + value = "{{env.acceptance-variable-terraform-test}}" + wait_for_nav_timeout = 50 } steps { name = "03 click" @@ -91,11 +102,11 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { selector_type = "id" type = "click_element" wait_for_nav = true + wait_for_nav_timeout = 2000 } steps { name = "04 accept---Alert" type = "accept_alert" - wait_for_nav = false } steps { name = "05 Select-val-text" @@ -105,6 +116,7 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { selector_type = "id" type = "select_option" wait_for_nav = false + wait_for_nav_timeout = 50 } } transactions { @@ -119,19 +131,36 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { selector = "beep" selector_type = "id" type = "enter_value" - value = "{{env.beep-var}}" + value = "{{env.acceptance-variable-terraform-test}}" + wait_for_nav_timeout = 50 + } + steps { + name = "assert element visible" + type = "assert_element_visible" + selector = "beep" + selector_type = "id" + max_wait_time = 1000 } } - } + } } ` const updatedBrowserCheckV2Config = ` +resource "synthetics_create_variable_v2" "variable_v2_foo" { + provider = synthetics.synthetics + variable { + description = "The most awesome variable. Full of snakes." + value = "barv3v3" + name = "acceptance-variable-terraform-test" + secret = false + } +} resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { provider = synthetics.synthetics test { active = false - device_id = 2 + device_id = 2 frequency = 15 location_ids = ["aws-us-west-1"] automatic_retries = 0 @@ -147,7 +176,7 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { collect_interactive_metrics = false authentication { username = "batmantis" - password = "{{env.beep-var}}" + password = "{{env.acceptance-variable-terraform-test}}" } headers { name = "superstar-machine-show" @@ -186,21 +215,23 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { } steps { name = "06 Select-Val-Val" - option_selector = "{{env.beep-var}}" + option_selector = "{{env.acceptance-variable-terraform-test}}" option_selector_type = "value" selector = "valz" selector_type = "id" type = "select_option" wait_for_nav = false + wait_for_nav_timeout = 50 } steps { name = "07 Select-Val-Index" - option_selector = "{{env.beep-var}}" + option_selector = "{{env.acceptance-variable-terraform-test}}" option_selector_type = "index" selector = "selectionz" selector_type = "id" type = "select_option" wait_for_nav = false + wait_for_nav_timeout = 50 } steps { name = "08 Save as text" @@ -208,13 +239,11 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { selector_type = "link" type = "store_variable_from_element" variable_name = "{{env.terraform-test-foo-301}}" - wait_for_nav = false } steps { name = "08.5 Wait" duration = 4234 type = "wait" - wait_for_nav = false } steps { name = "09 Save JS2 return Val" @@ -222,12 +251,14 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { value = "sdasds" variable_name = "{{env.terraform-test-foo-301}}" wait_for_nav = true + wait_for_nav_timeout = 2000 } steps { name = "010 Run JS" type = "run_javascript" value = "beeeeeeep" wait_for_nav = true + wait_for_nav_timeout = 2000 } } transactions { @@ -242,10 +273,18 @@ resource "synthetics_create_browser_check_v2" "browser_v2_foo_check" { selector = "beep" selector_type = "id" type = "enter_value" - value = "{{env.beep-var}}" + value = "{{env.acceptance-variable-terraform-test}}" + wait_for_nav_timeout = 50 + } + steps { + name = "assert element visible" + type = "assert_element_visible" + selector = "beep" + selector_type = "id" + max_wait_time = 1000 } } - } + } } ` @@ -273,7 +312,7 @@ func TestAccCreateUpdateBrowserCheckV2(t *testing.T) { resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.user_agent", "Mozilla/5.0 (X11; Linux x86_64; Splunk Synthetics) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.collect_interactive_metrics", "false"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.authentication.0.username", "batmab"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.authentication.0.password", "{{env.beep-var}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.authentication.0.password", "{{env.acceptance-variable-terraform-test}}"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.headers.0.name", "superstar-machine"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.headers.0.value", "\"taking it too the staaaaars\""), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.headers.0.domain", "asdasd.batman.com"), @@ -299,15 +338,15 @@ func TestAccCreateUpdateBrowserCheckV2(t *testing.T) { resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.selector", "beep"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.selector_type", "id"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.type", "enter_value"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.value", "{{env.beep-var}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.value", "{{env.acceptance-variable-terraform-test}}"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.name", "03 click"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.selector", "clicky"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.selector_type", "id"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.type", "click_element"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.wait_for_nav", "true"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.wait_for_nav_timeout", "2000"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.name", "04 accept---Alert"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.type", "accept_alert"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.wait_for_nav", "false"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.name", "05 Select-val-text"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.option_selector", "sdad"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.option_selector_type", "text"), @@ -315,6 +354,7 @@ func TestAccCreateUpdateBrowserCheckV2(t *testing.T) { resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.selector_type", "id"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.type", "select_option"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.wait_for_nav", "false"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.wait_for_nav_timeout", "50"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.name", "2nd Synthetic transaction"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.0.name", "Go to other URL"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.0.type", "go_to_url"), @@ -323,7 +363,12 @@ func TestAccCreateUpdateBrowserCheckV2(t *testing.T) { resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.selector", "beep"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.selector_type", "id"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.type", "enter_value"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.value", "{{env.beep-var}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.value", "{{env.acceptance-variable-terraform-test}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.name", "assert element visible"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.type", "assert_element_visible"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.selector", "beep"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.selector_type", "id"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.max_wait_time", "1000"), ), }, { @@ -350,7 +395,7 @@ func TestAccCreateUpdateBrowserCheckV2(t *testing.T) { resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.user_agent", "Jozilla/5.0"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.collect_interactive_metrics", "false"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.authentication.0.username", "batmantis"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.authentication.0.password", "{{env.beep-var}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.authentication.0.password", "{{env.acceptance-variable-terraform-test}}"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.headers.0.name", "superstar-machine-show"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.headers.0.value", "\"taking it too the stars\""), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.advanced_settings.0.headers.0.domain", "davidcrossed.batman.com"), @@ -373,38 +418,40 @@ func TestAccCreateUpdateBrowserCheckV2(t *testing.T) { resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.0.type", "go_to_url"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.0.url", "https://www.splunk.com"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.name", "06 Select-Val-Val"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.option_selector", "{{env.beep-var}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.option_selector", "{{env.acceptance-variable-terraform-test}}"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.option_selector_type", "value"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.selector", "valz"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.selector_type", "id"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.type", "select_option"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.wait_for_nav", "false"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.1.wait_for_nav_timeout", "50"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.name", "07 Select-Val-Index"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.option_selector", "{{env.beep-var}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.option_selector", "{{env.acceptance-variable-terraform-test}}"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.option_selector_type", "index"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.selector", "selectionz"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.selector_type", "id"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.type", "select_option"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.wait_for_nav", "false"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.2.wait_for_nav_timeout", "50"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.name", "08 Save as text"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.selector", "beepval"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.selector_type", "link"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.type", "store_variable_from_element"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.variable_name", "{{env.terraform-test-foo-301}}"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.3.wait_for_nav", "false"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.name", "08.5 Wait"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.duration", "4234"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.type", "wait"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.4.wait_for_nav", "false"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.5.name", "09 Save JS2 return Val"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.5.type", "store_variable_from_javascript"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.5.value", "sdasds"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.5.variable_name", "{{env.terraform-test-foo-301}}"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.5.wait_for_nav", "true"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.5.wait_for_nav_timeout", "2000"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.6.name", "010 Run JS"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.6.type", "run_javascript"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.6.value", "beeeeeeep"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.6.wait_for_nav", "true"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.0.steps.6.wait_for_nav_timeout", "2000"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.name", "2nd Synthetic transaction"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.0.name", "Go to other URL"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.0.type", "go_to_url"), @@ -413,7 +460,12 @@ func TestAccCreateUpdateBrowserCheckV2(t *testing.T) { resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.selector", "beep"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.selector_type", "id"), resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.type", "enter_value"), - resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.value", "{{env.beep-var}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.1.value", "{{env.acceptance-variable-terraform-test}}"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.name", "assert element visible"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.type", "assert_element_visible"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.selector", "beep"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.selector_type", "id"), + resource.TestCheckResourceAttr("synthetics_create_browser_check_v2.browser_v2_foo_check", "test.0.transactions.1.steps.2.max_wait_time", "1000"), ), }, }, diff --git a/synthetics/structures.go b/synthetics/structures.go index 6bdc1fc..f7ea819 100644 --- a/synthetics/structures.go +++ b/synthetics/structures.go @@ -963,6 +963,14 @@ func flattenStepsData(checkSteps *[]sc2.StepsV2) []interface{} { cl["wait_for_nav"] = checkStep.WaitForNav + if checkStep.WaitForNavTimeout != 0 { + cl["wait_for_nav_timeout"] = checkStep.WaitForNavTimeout + } + + if checkStep.MaxWaitTime != 0 { + cl["max_wait_time"] = checkStep.MaxWaitTime + } + if checkStep.Selector != "" { cl["selector"] = checkStep.Selector } @@ -1505,6 +1513,8 @@ func buildStepV2Data(steps []interface{}) []sc2.StepsV2 { Name: step["name"].(string), Type: step["type"].(string), WaitForNav: step["wait_for_nav"].(bool), + WaitForNavTimeout: step["wait_for_nav_timeout"].(int), + MaxWaitTime: step["max_wait_time"].(int), SelectorType: step["selector_type"].(string), Selector: step["selector"].(string), OptionSelectorType: step["option_selector_type"].(string),