Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(deps): update dependency org.sonarsource.java:sonar-java-… #831

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

hazendaz
Copy link
Member

…plugin to v7"

This reverts commit 397b4e2.

@hazendaz hazendaz self-assigned this Oct 31, 2023
@hazendaz
Copy link
Member Author

@gtoison Ok both are back. Do you know how this is released / used? Not familiar with it other than it was out of date and didn't have renovate on it and dependabot had previously given up.

@hazendaz hazendaz merged commit 1b75f3d into spotbugs:master Oct 31, 2023
7 checks passed
@gtoison
Copy link
Contributor

gtoison commented Oct 31, 2023

Most users get the plugin through the SonarQube marketplace. Once a version is published on Maven central we need to make a PR like SonarSource/sonar-update-center-properties#448 to get the new version approved.
The PR is generated a part of the release process by the GitHub Action that's inside the project.
The process is described here: https://github.com/spotbugs/sonar-findbugs/blob/master/RELEASE_PROCEDURE.md

That action has many dependencies and they are updated quite frequently. Considering how rarely it is used I did not see much value in constantly keeping up to date, so I had disabled dependabot. Due to my ignorance (I don't know Typescript) I'm also unsure if it is even working because the actual code running in the action is a transpiled index.js but these renovate PR do not update that file.

In my experience most of the java dependencies updates for this project require a bit more that changing a version number (running some scripts, fixing some tests, etc.), so I'm not 100% sold on the value of renovate (for this particular project) either. But I'd be happy to be proven wrong so I enabled renovate to give it another try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants