From d1c8b4490ca5c9ecb6fd01c9033e33fb066a84e5 Mon Sep 17 00:00:00 2001
From: Jeremy Landis <jeremylandis@hotmail.com>
Date: Sun, 15 Oct 2023 15:36:00 -0400
Subject: [PATCH] [config] Update spotbugs baseline files with newly uncovered
 hashCode fix in 4.8.0

---
 .../baseline/spotbugs-baseline-other.xml      | 29 ++++++++++++++++++-
 .../resources/baseline/spotbugs-baseline.xml  | 29 ++++++++++++++++++-
 2 files changed, 56 insertions(+), 2 deletions(-)

diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml
index 34ce0c6a..5740fd5e 100644
--- a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml
+++ b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml
@@ -16,7 +16,7 @@
     limitations under the License.
 
 -->
-<BugCollection sequence="0" release="" analysisTimestamp="1653586688929" version="4.7.0" timestamp="1653586685292">
+<BugCollection sequence="0" release="" analysisTimestamp="1697396613578" version="4.8.0" timestamp="1697396611249">
   <BugInstance instanceOccurrenceNum="0" instanceHash="c7f9edd192cfef80d2e55dde64a514bc" rank="2" abbrev="INT" category="CORRECTNESS" priority="1" type="INT_BAD_COMPARISON_WITH_SIGNED_BYTE" instanceOccurrenceMax="0">
     <ShortMessage>Bad comparison of signed byte</ShortMessage>
     <LongMessage>Bad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])</LongMessage>
@@ -54,6 +54,33 @@
       <Message>At UseOfNonHashableClassInHashDataStructure.java:[line 16]</Message>
     </SourceLine>
   </BugInstance>
+  <BugInstance instanceOccurrenceNum='0' instanceHash='39b83e2bc727181dff8f79450a6ccedb' rank='1' abbrev='HE' category='CORRECTNESS' priority='1' type='HE_USE_OF_UNHASHABLE_CLASS' instanceOccurrenceMax='0'>
+    <ShortMessage>Use of class without a hashCode() method in a hashed data structure</ShortMessage>
+    <LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)</LongMessage>
+    <Class classname='UseOfNonHashableClassInHashDataStructure' primary='true'>
+      <SourceLine classname='UseOfNonHashableClassInHashDataStructure' start='3' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java'>
+        <Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
+      </SourceLine>
+      <Message>In class UseOfNonHashableClassInHashDataStructure</Message>
+    </Class>
+    <Method isStatic='true' classname='UseOfNonHashableClassInHashDataStructure' signature='(LUseOfNonHashableClassInHashDataStructure;)Ljava/lang/String;' name='get' primary='true'>
+      <SourceLine endBytecode='34' classname='UseOfNonHashableClassInHashDataStructure' start='24' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java' startBytecode='0'></SourceLine>
+      <Message>In method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)</Message>
+    </Method>
+    <Type role='TYPE_UNHASHABLE' descriptor='LUseOfNonHashableClassInHashDataStructure;'>
+      <SourceLine classname='UseOfNonHashableClassInHashDataStructure' start='3' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java'>
+        <Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
+      </SourceLine>
+      <Message>Unhashable class UseOfNonHashableClassInHashDataStructure </Message>
+    </Type>
+    <Method isStatic='false' role='METHOD_CALLED' classname='java.util.HashMap' signature='(Ljava/lang/Object;)Ljava/lang/Object;' name='get'>
+      <SourceLine endBytecode='130' classname='java.util.HashMap' start='553' end='553' sourcepath='java/util/HashMap.java' sourcefile='HashMap.java' startBytecode='0'></SourceLine>
+      <Message>Called method java.util.HashMap.get(Object)</Message>
+    </Method>
+    <SourceLine endBytecode='4' classname='UseOfNonHashableClassInHashDataStructure' start='24' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java' startBytecode='4' primary='true'>
+      <Message>At UseOfNonHashableClassInHashDataStructure.java:[line 24]</Message>
+    </SourceLine>
+  </BugInstance>
   <BugInstance instanceOccurrenceNum="0" instanceHash="a4564c101ee03f13b56ee6a6b66efd77" rank="5" abbrev="HE" category="CORRECTNESS" priority="1" type="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS" instanceOccurrenceMax="0">
     <ShortMessage>Signature declares use of unhashable class in hashed construct</ShortMessage>
     <LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but it is used in a hashed context in UseOfNonHashableClassInHashDataStructure$UMap</LongMessage>
diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml
index 51124a2b..d1b84e29 100644
--- a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml
+++ b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml
@@ -16,7 +16,7 @@
     limitations under the License.
 
 -->
-<BugCollection sequence="0" release="" analysisTimestamp="1653586688929" version="4.7.0" timestamp="1653586685292">
+<BugCollection sequence="0" release="" analysisTimestamp="1697396613578" version="4.8.0" timestamp="1697396611249">
   <BugInstance instanceOccurrenceNum="0" instanceHash="a7786a4e4e4b9291a71529139eda42d1" rank="5" abbrev="IO" category="CORRECTNESS" priority="1" type="IO_APPENDING_TO_OBJECT_OUTPUT_STREAM" instanceOccurrenceMax="0">
     <ShortMessage>Doomed attempt to append to an object output stream</ShortMessage>
     <LongMessage>Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)</LongMessage>
@@ -122,6 +122,33 @@
       <Message>At UseOfNonHashableClassInHashDataStructure.java:[line 16]</Message>
     </SourceLine>
   </BugInstance>
+  <BugInstance instanceOccurrenceNum='0' instanceHash='39b83e2bc727181dff8f79450a6ccedb' rank='1' abbrev='HE' category='CORRECTNESS' priority='1' type='HE_USE_OF_UNHASHABLE_CLASS' instanceOccurrenceMax='0'>
+    <ShortMessage>Use of class without a hashCode() method in a hashed data structure</ShortMessage>
+    <LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)</LongMessage>
+    <Class classname='UseOfNonHashableClassInHashDataStructure' primary='true'>
+      <SourceLine classname='UseOfNonHashableClassInHashDataStructure' start='3' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java'>
+        <Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
+      </SourceLine>
+      <Message>In class UseOfNonHashableClassInHashDataStructure</Message>
+    </Class>
+    <Method isStatic='true' classname='UseOfNonHashableClassInHashDataStructure' signature='(LUseOfNonHashableClassInHashDataStructure;)Ljava/lang/String;' name='get' primary='true'>
+      <SourceLine endBytecode='34' classname='UseOfNonHashableClassInHashDataStructure' start='24' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java' startBytecode='0'></SourceLine>
+      <Message>In method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)</Message>
+    </Method>
+    <Type role='TYPE_UNHASHABLE' descriptor='LUseOfNonHashableClassInHashDataStructure;'>
+      <SourceLine classname='UseOfNonHashableClassInHashDataStructure' start='3' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java'>
+        <Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
+      </SourceLine>
+      <Message>Unhashable class UseOfNonHashableClassInHashDataStructure </Message>
+    </Type>
+    <Method isStatic='false' role='METHOD_CALLED' classname='java.util.HashMap' signature='(Ljava/lang/Object;)Ljava/lang/Object;' name='get'>
+      <SourceLine endBytecode='130' classname='java.util.HashMap' start='553' end='553' sourcepath='java/util/HashMap.java' sourcefile='HashMap.java' startBytecode='0'></SourceLine>
+      <Message>Called method java.util.HashMap.get(Object)</Message>
+    </Method>
+    <SourceLine endBytecode='4' classname='UseOfNonHashableClassInHashDataStructure' start='24' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java' startBytecode='4' primary='true'>
+      <Message>At UseOfNonHashableClassInHashDataStructure.java:[line 24]</Message>
+    </SourceLine>
+  </BugInstance>
   <BugInstance instanceOccurrenceNum="0" instanceHash="a4564c101ee03f13b56ee6a6b66efd77" rank="5" abbrev="HE" category="CORRECTNESS" priority="1" type="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS" instanceOccurrenceMax="0">
     <ShortMessage>Signature declares use of unhashable class in hashed construct</ShortMessage>
     <LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but it is used in a hashed context in UseOfNonHashableClassInHashDataStructure$UMap</LongMessage>