Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default encoding should be UTF-8 #946

Open
elharo opened this issue Nov 29, 2024 · 1 comment
Open

Default encoding should be UTF-8 #946

elharo opened this issue Nov 29, 2024 · 1 comment

Comments

@elharo
Copy link

elharo commented Nov 29, 2024

From the SpotBugs mojo

    /**
     * The file encoding to use when creating the HTML reports. If the property <code>project.reporting.outputEncoding</code>
     * is not set, the platform default encoding is used.
     *
     * @since 2.2
     */
    @Parameter(defaultValue = '${project.reporting.outputEncoding}', property = 'outputEncoding')
    String outputEncoding

In 2024 platform default encoding is almost never a good idea. The default should be UTF-8. On Mac OS X or in JDK 21, the default encoding is likely to be UTF-8 anyway.

https://openjdk.org/jeps/400

@hazendaz
Copy link
Member

hazendaz commented Dec 1, 2024

Actually it probably is internally UTF_8 everywhere it not supplied because that is all I've used in more than a decade at this point. I'll review as it may just be that the javadoc is entirely wrong now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants