Skip to content
This repository was archived by the owner on Feb 23, 2020. It is now read-only.

Commit 552647a

Browse files
Jeff DutilJeff Dutil
authored andcommitted
Fix position as acts_as_list uses 1 default.
1 parent ab01670 commit 552647a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

spec/serializers/spree/wombat/product_serializer_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ module Wombat
9494
ActionController::Base.asset_host = "http://myapp.dev"
9595
image = File.open(File.expand_path('../../../../fixtures/thinking-cat.jpg', __FILE__))
9696
3.times.each_with_index do |i|
97-
product.images.create!(attachment: image, position: i, alt: "variant image #{i}")
97+
product.images.create!(attachment: image, alt: "variant image #{i}")
9898
end
9999
end
100100

@@ -103,7 +103,7 @@ module Wombat
103103
dimension_hash = {"height" => 490, "width" => 489}
104104
3.times.each_with_index do |i|
105105
expect(serialized_product["images"][i]["url"]).to match /http:\/\/myapp.dev\/spree\/products\/\d*\/original\/thinking-cat.jpg\z/
106-
expect(serialized_product["images"][i]["position"]).to eql i
106+
expect(serialized_product["images"][i]["position"]).to eql (i + 1)
107107
expect(serialized_product["images"][i]["title"]).to eql "variant image #{i}"
108108
expect(serialized_product["images"][i]["type"]).to eql "original"
109109
expect(serialized_product["images"][i]["dimensions"]).to eql dimension_hash

spec/serializers/spree/wombat/variant_serializer_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ module Wombat
5353
ActionController::Base.asset_host = "http://myapp.dev"
5454
image = File.open(File.expand_path('../../../../fixtures/thinking-cat.jpg', __FILE__))
5555
3.times.each_with_index do |i|
56-
variant.images.create!(attachment: image, position: i, alt: "variant image #{i}")
56+
variant.images.create!(attachment: image, alt: "variant image #{i}")
5757
end
5858
end
5959

@@ -62,7 +62,7 @@ module Wombat
6262
dimension_hash = {"height" => 490, "width" => 489}
6363
3.times.each_with_index do |i|
6464
expect(serialized_variant["images"][i]["url"]).to match /http:\/\/myapp.dev\/spree\/products\/\d*\/original\/thinking-cat.jpg\z/
65-
expect(serialized_variant["images"][i]["position"]).to eql i
65+
expect(serialized_variant["images"][i]["position"]).to eql (i + 1)
6666
expect(serialized_variant["images"][i]["title"]).to eql "variant image #{i}"
6767
expect(serialized_variant["images"][i]["type"]).to eql "original"
6868
expect(serialized_variant["images"][i]["dimensions"]).to eql dimension_hash

0 commit comments

Comments
 (0)