respond properly if variant not found

Author: huoxito

lib/spree/wombat/handler/update_product_handler.rb

@@ -7,8 +7,14 @@ class UpdateProductHandler < ProductHandlerBase
 
         def process
           id = params.delete(:id)
-          product = Spree::Variant.where(is_master: true, sku: params[:sku]).first.product
-          return response("Cannot find product with SKU #{params[:sku]}!", 500) unless product
+          variant = Variant.where(is_master: true, sku: params[:sku]).first
+
+          if variant.nil? || variant.product.nil?
+            return response("Cannot find product with SKU #{params[:sku]}!", 500)
+          end
+
+          product = variant.product
+
           # Disable the after_touch callback on taxons
           Spree::Product.skip_callback(:touch, :after, :touch_taxons)
 

spec/lib/spree/wombat/handler/update_product_handler_spec.rb

@@ -3,12 +3,17 @@
 module Spree
   module Wombat
     describe Handler::UpdateProductHandler do
-
       before do
         img_fixture = File.open(File.expand_path('../../../../../fixtures/thinking-cat.jpg', __FILE__))
         URI.stub(:parse).and_return img_fixture
       end
 
+      it "respond properly if product not found" do
+        handler = described_class.new Hub::Samples::Product.request.to_json
+        response = handler.process
+        expect(response.summary).to match "Cannot find product with SKU"
+      end
+
       context "#process" do
         let!(:message) do
           hsh = ::Hub::Samples::Product.request