Remove schedule. deprecated property key prefix #6043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the users going to receive an error when they use |
|
Great Question. In both implementations they check for a empty/null cron expression and will throw an exception. |
Will users experience failure if they don't recreate their schedules with modified properties? |
|
The existing schedules will still be managed by the scheduler/cronjob, until they are shutdown by SCDF or by administrator. |
Use deployer. property prefix when setting schedule properties Originally scheduled properties uses schedule. as a prefix for all the settings. However it was determined they were just a subset of deployer properties and thus could be deprecated Signed-off-by: Glenn Renfro <grenfro@vmware.com> polish Signed-off-by: Glenn Renfro <grenfro@vmware.com>
Polish Signed-off-by: Glenn Renfro <grenfro@vmware.com>
|
Thanks @corneil for the review!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use deployer. property prefix when setting schedule properties
Originally scheduled properties uses
schedule.as a prefix for all the settings. However it was determined they were just a subset of deployer properties and thus the prefix could be deprecated.resolves #6019