Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline ChatOptions #1203

Merged

Conversation

ThomasVitale
Copy link
Contributor

  • Surface more configuration APIs to ChatOptions
  • Use abstraction in Observations directly instead of dedicated implementation
  • Simplify metadata config in observations for defined models
  • Improve merging of runtime and default options in OpenAI
  • Fix missing option in Mistral AI

Relates to gh-1148

* Surface more configuration APIs to ChatOptions
* Use abstraction in Observations directly instead of dedicated implementation
* Simplify metadata config in observations for defined models
* Improve merging of runtime and default options in OpenAI
* Fix missing option in Mistral AI

Relates to spring-projectsgh-1148

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@tzolov
Copy link
Contributor

tzolov commented Aug 11, 2024

Great job @ThomasVitale , thanks.
I scanned through the code and have not remarks or suggestion.
I guess in the future we can improve some repetitive code in the call and stream observation instrumentation. But this is minor and not related to this PR.
Great stuff!

@tzolov tzolov merged commit bf84d59 into spring-projects:main Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants