-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling stream advisor responses #1293
Handling stream advisor responses #1293
Conversation
@@ -410,6 +388,47 @@ public String content() { | |||
|
|||
} | |||
|
|||
public static Prompt toPrompt(DefaultChatClientRequestSpec advisedRequest, String formatParam) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be protected instead of public.
advisedResponse = advisor.adviseResponse(advisedResponse, context); | ||
advisedResponse = AdvisorObservableHelper.adviseResponse(parentObservation, advisor, | ||
advisedResponse, context); | ||
// advisedResponse = advisor.adviseResponse(advisedResponse, context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed commented out line
@@ -151,4 +140,9 @@ protected Filter.Expression doGetFilterExpression(Map<String, Object> context) { | |||
|
|||
} | |||
|
|||
@Override | |||
public StreamResponseMode getStreamResponseMode() { | |||
return StreamResponseMode.ON_FINISH_REASON; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not AGGREGATE?
Merged at bf8dabf |
No description provided.