Fix problem with VectorStoreChatMemoryAdvisor using pgvector #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabapp2
force-pushed
the
fk/issue800
branch
2 times, most recently
from
e208bc5
to
57b36d8
Compare
- add integration test
|
Thanks you @fabapp2 . Especially for the additional test ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
VectorStoreChatMemoryAdvisoris used theSELECTfrom the pgvector store failed with a SQL error.This PR fixes the SQL by removing the
'as reported.I tried to provide a useful test that verifies the correct behaviour when
VectorStoreChatMemoryAdvisoris used.It verifies that chat messages are enriched with similar messages from the vector store. This query was failing.