Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for BatchingStrategy in vector stores #1424

Closed

Conversation

sobychacko
Copy link
Contributor

  • Explain the need for batching due to embedding model thresholds
  • Describe the BatchingStrategy interface and its purpose
  • Detail the default TokenCountBatchingStrategy implementation
  • Provide information on using and customizing batching strategies
  • Mention that several vector stores are pre-configured with the default strategy

- Explain the need for batching due to embedding model thresholds
- Describe the BatchingStrategy interface and its purpose
- Detail the default TokenCountBatchingStrategy implementation
- Provide information on using and customizing batching strategies
- Mention that several vector stores are pre-configured with the default strategy
@markpollack
Copy link
Member

Added new constructor for custom TokenCountEstimator in TokenCountBatchingStrategy and null checks in ctors

updated doc with example usage of additional constructors

merged in 4c8a6ee

@markpollack markpollack added this to the 1.0.0-M3 milestone Sep 28, 2024
@markpollack markpollack self-assigned this Sep 28, 2024
@markpollack markpollack added documentation Improvements or additions to documentation embedding labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation embedding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants