improvement based MiniMax model client #744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inappropriate method
|
Hi, thanks!! Sorry to cross issues, but there was a similar missing implementation of |
Got it. Would you like to submit a commit to this PR or create a new one? |
@markpollack I am not sure about the PR specification for cross issues, so I created a new one, #746 . If you need to squash in this pr, please contact me. |
|
merged as ef5a3fa thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an improvement based on the review feedback for the previous PR #628.
the PR content:
fromMediaData, because theMiniMaxdoes not support media, link.FUNCTION, linkdoChatCompletionStreammethod for the abstract class AbstractFunctionCallSupport, link