Skip to content

Commit 4e86ff0

Browse files
committed
Adapt to deprecations in latest Framework snaphots
See gh-47850
1 parent 578b199 commit 4e86ff0

File tree

3 files changed

+21
-10
lines changed

3 files changed

+21
-10
lines changed

integration-test/spring-boot-actuator-integration-tests/src/test/java/org/springframework/boot/actuate/context/properties/ConfigurationPropertiesReportEndpointWebIntegrationTests.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.boot.actuate.context.properties;
1818

1919
import java.util.Collections;
20+
import java.util.List;
2021

2122
import org.junit.jupiter.api.BeforeEach;
2223

@@ -30,8 +31,7 @@
3031
import org.springframework.context.annotation.Configuration;
3132
import org.springframework.test.web.reactive.server.WebTestClient;
3233

33-
import static org.hamcrest.Matchers.greaterThanOrEqualTo;
34-
import static org.hamcrest.Matchers.hasSize;
34+
import static org.assertj.core.api.Assertions.assertThat;
3535

3636
/**
3737
* Integration tests for {@link ConfigurationPropertiesReportEndpoint} exposed by Jersey,
@@ -50,6 +50,7 @@ void prepareEnvironment(ConfigurableApplicationContext context, WebTestClient cl
5050
}
5151

5252
@WebEndpointTest
53+
@SuppressWarnings("unchecked")
5354
void noFilters() {
5455
this.client.get()
5556
.uri("/actuator/configprops")
@@ -58,14 +59,15 @@ void noFilters() {
5859
.isOk()
5960
.expectBody()
6061
.jsonPath("$..beans[*]")
61-
.value(hasSize(greaterThanOrEqualTo(2)))
62+
.value(List.class, (beans) -> assertThat(beans).hasSizeGreaterThanOrEqualTo(2))
6263
.jsonPath("$..beans['fooDotCom']")
6364
.exists()
6465
.jsonPath("$..beans['barDotCom']")
6566
.exists();
6667
}
6768

6869
@WebEndpointTest
70+
@SuppressWarnings("unchecked")
6971
void filterByExactPrefix() {
7072
this.client.get()
7173
.uri("/actuator/configprops/com.foo")
@@ -74,12 +76,13 @@ void filterByExactPrefix() {
7476
.isOk()
7577
.expectBody()
7678
.jsonPath("$..beans[*]")
77-
.value(hasSize(1))
79+
.value(List.class, (beans) -> assertThat(beans).hasSize(1))
7880
.jsonPath("$..beans['fooDotCom']")
7981
.exists();
8082
}
8183

8284
@WebEndpointTest
85+
@SuppressWarnings("unchecked")
8386
void filterByGeneralPrefix() {
8487
this.client.get()
8588
.uri("/actuator/configprops/com.")
@@ -88,7 +91,7 @@ void filterByGeneralPrefix() {
8891
.isOk()
8992
.expectBody()
9093
.jsonPath("$..beans[*]")
91-
.value(hasSize(2))
94+
.value(List.class, (beans) -> assertThat(beans).hasSize(2))
9295
.jsonPath("$..beans['fooDotCom']")
9396
.exists()
9497
.jsonPath("$..beans['barDotCom']")

integration-test/spring-boot-actuator-integration-tests/src/test/java/org/springframework/boot/actuate/logging/LoggersEndpointWebIntegrationTests.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import java.util.Map;
2525

2626
import net.minidev.json.JSONArray;
27-
import org.hamcrest.collection.IsIterableContainingInAnyOrder;
2827
import org.junit.jupiter.api.AfterEach;
2928
import org.junit.jupiter.api.BeforeEach;
3029
import org.mockito.Mockito;
@@ -39,9 +38,11 @@
3938
import org.springframework.context.ConfigurableApplicationContext;
4039
import org.springframework.context.annotation.Bean;
4140
import org.springframework.context.annotation.Configuration;
41+
import org.springframework.core.ParameterizedTypeReference;
4242
import org.springframework.http.MediaType;
4343
import org.springframework.test.web.reactive.server.WebTestClient;
4444

45+
import static org.assertj.core.api.Assertions.assertThat;
4546
import static org.mockito.BDDMockito.given;
4647
import static org.mockito.BDDMockito.then;
4748
import static org.mockito.Mockito.mock;
@@ -64,6 +65,9 @@ class LoggersEndpointWebIntegrationTests {
6465

6566
private static final String V3_JSON = ApiVersion.V3.getProducedMimeType().toString();
6667

68+
private static final ParameterizedTypeReference<List<String>> STRING_LIST = new ParameterizedTypeReference<>() {
69+
};
70+
6771
private WebTestClient client;
6872

6973
private LoggingSystem loggingSystem;
@@ -134,6 +138,7 @@ void getLoggersWhenLoggerAndLoggerGroupNotFoundShouldReturnNotFound() {
134138
}
135139

136140
@WebEndpointTest
141+
@SuppressWarnings("unchecked")
137142
void getLoggerGroupShouldReturnConfiguredLogLevelAndMembers() {
138143
setLogLevelToDebug("test");
139144
this.client.get()
@@ -145,7 +150,8 @@ void getLoggerGroupShouldReturnConfiguredLogLevelAndMembers() {
145150
.jsonPath("$.length()")
146151
.isEqualTo(2)
147152
.jsonPath("members")
148-
.value(IsIterableContainingInAnyOrder.containsInAnyOrder("test.member1", "test.member2"))
153+
.value(STRING_LIST,
154+
(members) -> assertThat(members).containsExactlyInAnyOrder("test.member1", "test.member2"))
149155
.jsonPath("configuredLevel")
150156
.isEqualTo("DEBUG");
151157
}
@@ -293,6 +299,7 @@ void logLevelForLoggerWithNameThatCouldBeMistakenForAPathExtension() {
293299
}
294300

295301
@WebEndpointTest
302+
@SuppressWarnings("unchecked")
296303
void logLevelForLoggerGroupWithNameThatCouldBeMistakenForAPathExtension() {
297304
setLogLevelToDebug("group.png");
298305
this.client.get()
@@ -306,7 +313,8 @@ void logLevelForLoggerGroupWithNameThatCouldBeMistakenForAPathExtension() {
306313
.jsonPath("configuredLevel")
307314
.isEqualTo("DEBUG")
308315
.jsonPath("members")
309-
.value(IsIterableContainingInAnyOrder.containsInAnyOrder("png.member1", "png.member2"));
316+
.value(STRING_LIST,
317+
(members) -> assertThat(members).containsExactlyInAnyOrder("png.member1", "png.member2"));
310318
}
311319

312320
private void setLogLevelToDebug(String name) {

module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/reactive/GraphQlWebFluxAutoConfigurationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import java.util.function.Consumer;
2323

2424
import graphql.schema.idl.TypeRuntimeWiring;
25+
import org.jspecify.annotations.Nullable;
2526
import org.junit.jupiter.api.Test;
2627
import reactor.core.publisher.Mono;
2728

@@ -53,7 +54,6 @@
5354
import org.springframework.web.reactive.function.server.RouterFunction;
5455

5556
import static org.assertj.core.api.Assertions.assertThat;
56-
import static org.hamcrest.Matchers.containsString;
5757

5858
/**
5959
* Tests for {@link GraphQlWebFluxAutoConfiguration}
@@ -209,7 +209,7 @@ void shouldExposeSchemaEndpoint() {
209209
.expectHeader()
210210
.contentType(MediaType.TEXT_PLAIN)
211211
.expectBody(String.class)
212-
.value(containsString("type Book")));
212+
.value((Consumer<@Nullable String>) (body) -> assertThat(body).contains("type Book")));
213213
}
214214

215215
@Test

0 commit comments

Comments
 (0)