Skip to content

Commit 785fbff

Browse files
committed
Allow skipping unavailable override configurations in Log4j2
Introduced support for the 'optional:' prefix in Log4j2 override file locations, ensuring missing files are ignored without throwing exceptions. See gh-44399 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
1 parent 83f678a commit 785fbff

File tree

3 files changed

+89
-14
lines changed

3 files changed

+89
-14
lines changed

spring-boot-project/spring-boot-docs/src/docs/antora/modules/how-to/pages/logging.adoc

+2
Original file line numberDiff line numberDiff line change
@@ -201,3 +201,5 @@ To configure Log4j 2 to use an alternative configuration file format, add the ap
201201
Log4j 2 has support for combining multiple configuration files into a single composite configuration.
202202
To use this support in Spring Boot, configure configprop:logging.log4j2.config.override[] with the locations of one or more secondary configuration files.
203203
The secondary configuration files will be merged with the primary configuration, whether the primary's source is Spring Boot's defaults, a standard location such as `log4j.xml`, or the location configured by the configprop:logging.config[] property.
204+
205+
NOTE: Log4j2 override configuration file locations can be prefixed with `optional:`, for example, `optional:classpath:log4j2-override.xml`, to indicate that the location is optional and should only be loaded if the resource exists.

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/log4j2/Log4J2LoggingSystem.java

+44-14
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.boot.logging.log4j2;
1818

19+
import java.io.FileNotFoundException;
1920
import java.io.IOException;
2021
import java.io.InputStream;
2122
import java.net.URL;
@@ -69,6 +70,7 @@
6970
import org.springframework.core.annotation.Order;
7071
import org.springframework.core.env.Environment;
7172
import org.springframework.core.io.Resource;
73+
import org.springframework.core.io.ResourceLoader;
7274
import org.springframework.util.Assert;
7375
import org.springframework.util.ClassUtils;
7476
import org.springframework.util.CollectionUtils;
@@ -86,6 +88,8 @@
8688
*/
8789
public class Log4J2LoggingSystem extends AbstractLoggingSystem {
8890

91+
private static final String OPTIONAL_PREFIX = "optional:";
92+
8993
private static final String LOG4J_BRIDGE_HANDLER = "org.apache.logging.log4j.jul.Log4jBridgeHandler";
9094

9195
private static final String LOG4J_LOG_MANAGER = "org.apache.logging.log4j.jul.LogManager";
@@ -270,21 +274,42 @@ protected void loadConfiguration(String location, LogFile logFile, List<String>
270274
try {
271275
List<Configuration> configurations = new ArrayList<>();
272276
LoggerContext context = getLoggerContext();
273-
configurations.add(load(location, context));
277+
ResourceLoader resourceLoader = ApplicationResourceLoader.get();
278+
configurations.add(loadConfiguration(resourceLoader, location, context));
274279
for (String override : overrides) {
275-
configurations.add(load(override, context));
280+
Configuration overrideConfiguration = loadOptionalConfiguration(resourceLoader, override, context);
281+
if (overrideConfiguration != null) {
282+
configurations.add(overrideConfiguration);
283+
}
276284
}
277-
Configuration configuration = (configurations.size() > 1) ? createComposite(configurations)
278-
: configurations.iterator().next();
279-
context.start(configuration);
285+
context.start(createCompositeConfigurationIfNecessary(configurations));
280286
}
281287
catch (Exception ex) {
282288
throw new IllegalStateException("Could not initialize Log4J2 logging from " + location, ex);
283289
}
284290
}
285291

286-
private Configuration load(String location, LoggerContext context) throws IOException {
287-
Resource resource = ApplicationResourceLoader.get().getResource(location);
292+
private Configuration loadOptionalConfiguration(ResourceLoader resourceLoader, String location,
293+
LoggerContext context) throws IOException {
294+
if (location.startsWith(OPTIONAL_PREFIX)) {
295+
Resource resource = resourceLoader.getResource(location.substring(OPTIONAL_PREFIX.length()));
296+
try {
297+
return (resource.exists()) ? loadConfiguration(resource, context) : null;
298+
}
299+
catch (FileNotFoundException ex) {
300+
return null;
301+
}
302+
}
303+
return loadConfiguration(resourceLoader, location, context);
304+
}
305+
306+
private Configuration loadConfiguration(ResourceLoader resourceLoader, String location, LoggerContext context)
307+
throws IOException {
308+
Resource resource = resourceLoader.getResource(location);
309+
return loadConfiguration(resource, context);
310+
}
311+
312+
private Configuration loadConfiguration(Resource resource, LoggerContext context) throws IOException {
288313
ConfigurationFactory factory = ConfigurationFactory.getInstance();
289314
if (resource.isFile()) {
290315
try (InputStream inputStream = resource.getInputStream()) {
@@ -304,7 +329,10 @@ private Configuration load(String location, LoggerContext context) throws IOExce
304329
}
305330
}
306331

307-
private CompositeConfiguration createComposite(List<Configuration> configurations) {
332+
private Configuration createCompositeConfigurationIfNecessary(List<Configuration> configurations) {
333+
if (configurations.size() == 1) {
334+
return configurations.iterator().next();
335+
}
308336
return new CompositeConfiguration(configurations.stream().map(AbstractConfiguration.class::cast).toList());
309337
}
310338

@@ -322,19 +350,21 @@ protected void reinitialize(LoggingInitializationContext initializationContext)
322350

323351
private void reinitializeWithOverrides(List<String> overrides) {
324352
LoggerContext context = getLoggerContext();
325-
Configuration base = context.getConfiguration();
326-
List<AbstractConfiguration> configurations = new ArrayList<>();
327-
configurations.add((AbstractConfiguration) base);
353+
List<Configuration> configurations = new ArrayList<>();
354+
configurations.add(context.getConfiguration());
355+
ResourceLoader resourceLoader = ApplicationResourceLoader.get();
328356
for (String override : overrides) {
329357
try {
330-
configurations.add((AbstractConfiguration) load(override, context));
358+
Configuration overrideConfiguration = loadOptionalConfiguration(resourceLoader, override, context);
359+
if (overrideConfiguration != null) {
360+
configurations.add(overrideConfiguration);
361+
}
331362
}
332363
catch (IOException ex) {
333364
throw new RuntimeException("Failed to load overriding configuration from '" + override + "'", ex);
334365
}
335366
}
336-
CompositeConfiguration composite = new CompositeConfiguration(configurations);
337-
context.reconfigure(composite);
367+
context.reconfigure(createCompositeConfigurationIfNecessary(configurations));
338368
}
339369

340370
@Override

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/log4j2/Log4J2LoggingSystemTests.java

+43
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
import org.apache.logging.log4j.core.config.Reconfigurable;
4444
import org.apache.logging.log4j.core.config.composite.CompositeConfiguration;
4545
import org.apache.logging.log4j.core.config.plugins.util.PluginRegistry;
46+
import org.apache.logging.log4j.core.config.xml.XmlConfiguration;
4647
import org.apache.logging.log4j.core.util.ShutdownCallbackRegistry;
4748
import org.apache.logging.log4j.jul.Log4jBridgeHandler;
4849
import org.apache.logging.log4j.status.StatusListener;
@@ -453,6 +454,48 @@ void shutdownHookIsDisabled() {
453454
.isFalse();
454455
}
455456

457+
@Test
458+
@WithNonDefaultXmlResource
459+
void loadOptionalOverrideConfigurationWhenDoesNotExist() {
460+
this.environment.setProperty("logging.log4j2.config.override", "optional:classpath:override.xml");
461+
this.loggingSystem.initialize(this.initializationContext, "classpath:nondefault.xml", null);
462+
assertThat(this.loggingSystem.getConfiguration()).isInstanceOf(XmlConfiguration.class);
463+
}
464+
465+
@Test
466+
void loadOptionalOverrideConfigurationWhenDoesNotExistUponReinitialization() {
467+
this.environment.setProperty("logging.log4j2.config.override", "optional:classpath:override.xml");
468+
this.loggingSystem.beforeInitialize();
469+
this.loggingSystem.initialize(this.initializationContext, null, null);
470+
assertThat(this.loggingSystem.getConfiguration()).isInstanceOf(XmlConfiguration.class);
471+
this.loggingSystem.cleanUp();
472+
this.loggingSystem.beforeInitialize();
473+
this.loggingSystem.initialize(this.initializationContext, null, null);
474+
assertThat(this.loggingSystem.getConfiguration()).isInstanceOf(XmlConfiguration.class);
475+
}
476+
477+
@Test
478+
@WithNonDefaultXmlResource
479+
@WithOverrideXmlResource
480+
void loadOptionalOverrideConfiguration() {
481+
this.environment.setProperty("logging.log4j2.config.override", "optional:classpath:override.xml");
482+
this.loggingSystem.initialize(this.initializationContext, "classpath:nondefault.xml", null);
483+
assertThat(this.loggingSystem.getConfiguration()).isInstanceOf(CompositeConfiguration.class);
484+
}
485+
486+
@Test
487+
@WithOverrideXmlResource
488+
void loadOptionalOverrideConfigurationUponReinitialization() {
489+
this.environment.setProperty("logging.log4j2.config.override", "optional:classpath:override.xml");
490+
this.loggingSystem.beforeInitialize();
491+
this.loggingSystem.initialize(this.initializationContext, null, null);
492+
assertThat(this.loggingSystem.getConfiguration()).isInstanceOf(CompositeConfiguration.class);
493+
this.loggingSystem.cleanUp();
494+
this.loggingSystem.beforeInitialize();
495+
this.loggingSystem.initialize(this.initializationContext, null, null);
496+
assertThat(this.loggingSystem.getConfiguration()).isInstanceOf(CompositeConfiguration.class);
497+
}
498+
456499
@Test
457500
@WithNonDefaultXmlResource
458501
@WithOverrideXmlResource

0 commit comments

Comments
 (0)