Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine RedisSerializer implementations #1097

Closed
spring-projects-issues opened this issue Jun 14, 2016 · 1 comment
Closed

Refine RedisSerializer implementations #1097

spring-projects-issues opened this issue Jun 14, 2016 · 1 comment
Assignees
@mp911de
Labels
in: core Issues in core support type: task A general task
Milestone
3.0.11 (2022.0.11)

Comments

@spring-projects-issues
Copy link

Markus Heiden opened DATAREDIS-521 and commented

Jackson2JsonRedisSerializer#serialize(Object) should be Jackson2JsonRedisSerializer#serialize(T). Jackson2JsonRedisSerializer implements RedisSerializer<T> which defines the method as serialize(T). I do not understand why this compiles at all.

The current state makes it impossible to overwrite the method

Affects: 1.7.1 (Hopper SR1)
@spring-projects-issues spring-projects-issues added type: bug A general bug in: core Issues in core support labels Dec 30, 2020
@mp911de
Copy link
Member

mp911de commented Sep 21, 2023

Jackson2JsonRedisSerializer.serialize(T) compiles to serialize(Object). We took this opportunity to polish up our code a bit.

@mp911de mp911de changed the title JacksonJsonRedisSerializer#serialize type safety [DATAREDIS-521] Revise RedisSerializer implementations Sep 21, 2023
@mp911de mp911de assigned mp911de and unassigned christophstrobl Sep 21, 2023
@mp911de mp911de added type: task A general task and removed type: bug A general bug labels Sep 21, 2023
@mp911de mp911de changed the title Revise RedisSerializer implementations Refine RedisSerializer implementations Sep 21, 2023
@mp911de mp911de added this to the 3.0.11 (2022.0.11) milestone Sep 21, 2023
mp911de added a commit that referenced this issue Sep 21, 2023
@mp911de
Refine RedisSerializer implementations.
6a51b3d 
This commit polishes up method ordering, introduces Javadoc where missing and updates nullability annotations and argument names.

Closes #1097
mp911de added a commit that referenced this issue Sep 21, 2023
@mp911de
Refine RedisSerializer implementations.
060e3fd 
This commit polishes up method ordering, introduces Javadoc where missing and updates nullability annotations and argument names.

Closes #1097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
in: core Issues in core support type: task A general task
Projects
None yet
Milestone
3.0.11 (2022.0.11)
Development

No branches or pull requests
3 participants
@mp911de @christophstrobl @spring-projects-issues