Fix lint errors and add lint checks to CI

Author: Eugene Dementyev

.github/workflows/build_test.yml

@@ -9,29 +9,27 @@ jobs:
     name: test if ssm-parent can be built
     runs-on: ubuntu-latest
     steps:
-      -
-        name: checkout
-        uses: actions/checkout@v2
-      -
-        name: set up Go
-        uses: actions/setup-go@v1
+      - name: checkout
+        uses: actions/checkout@v3
+      - name: set up Go
+        uses: actions/setup-go@v3
         with:
           go-version: 1.17.x
-      -
-        name: cache modules
+      - name: cache modules
         uses: actions/cache@v2
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
-      -
-        name: download dependencies
+
+      - name: download dependencies
         run: go mod download
-      -
-        name: build the app
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
+
+      - name: build the app
         run: go build
-      -
-        name: test the app
+      - name: test the app
         run: go test -v ./...
-

cmd/root.go

@@ -123,15 +123,21 @@ func init() {
 	rootCmd.PersistentFlags().BoolP("recursive", "r", false, "Walk through the provided SSM paths recursively.")
 	rootCmd.PersistentFlags().BoolP("strict", "s", false, "Strict mode. Fail if found less parameters than number of names.")
 
-	viper.BindPFlag("debug", rootCmd.PersistentFlags().Lookup("debug"))
-	viper.BindPFlag("expand", rootCmd.PersistentFlags().Lookup("expand"))
-	viper.BindPFlag("expand-names", rootCmd.PersistentFlags().Lookup("expand-names"))
-	viper.BindPFlag("expand-paths", rootCmd.PersistentFlags().Lookup("expand-paths"))
-	viper.BindPFlag("expand-values", rootCmd.PersistentFlags().Lookup("expand-values"))
-	viper.BindPFlag("paths", rootCmd.PersistentFlags().Lookup("path"))
-	viper.BindPFlag("names", rootCmd.PersistentFlags().Lookup("name"))
-	viper.BindPFlag("plain-paths", rootCmd.PersistentFlags().Lookup("plain-path"))
-	viper.BindPFlag("plain-names", rootCmd.PersistentFlags().Lookup("plain-name"))
-	viper.BindPFlag("recursive", rootCmd.PersistentFlags().Lookup("recursive"))
-	viper.BindPFlag("strict", rootCmd.PersistentFlags().Lookup("strict"))
+	for _, err := range []error{
+		viper.BindPFlag("debug", rootCmd.PersistentFlags().Lookup("debug")),
+		viper.BindPFlag("expand", rootCmd.PersistentFlags().Lookup("expand")),
+		viper.BindPFlag("expand-names", rootCmd.PersistentFlags().Lookup("expand-names")),
+		viper.BindPFlag("expand-paths", rootCmd.PersistentFlags().Lookup("expand-paths")),
+		viper.BindPFlag("expand-values", rootCmd.PersistentFlags().Lookup("expand-values")),
+		viper.BindPFlag("paths", rootCmd.PersistentFlags().Lookup("path")),
+		viper.BindPFlag("names", rootCmd.PersistentFlags().Lookup("name")),
+		viper.BindPFlag("plain-paths", rootCmd.PersistentFlags().Lookup("plain-path")),
+		viper.BindPFlag("plain-names", rootCmd.PersistentFlags().Lookup("plain-name")),
+		viper.BindPFlag("recursive", rootCmd.PersistentFlags().Lookup("recursive")),
+		viper.BindPFlag("strict", rootCmd.PersistentFlags().Lookup("strict")),
+	} {
+		if err != nil {
+			log.WithError(err).Fatalf("can't bind flags")
+		}
+	}
 }

ssm/parameters.go

@@ -187,9 +187,7 @@ func getAllParameters(names, paths, plainNames, plainPaths []string, strict, rec
 				log.Fields{"paths": paths},
 			).Fatal("Can't get parameters by paths")
 		}
-		for _, parameter := range parametersFromPaths {
-			parameters = append(parameters, parameter)
-		}
+		parameters = append(parameters, parametersFromPaths...)
 	}
 	if len(names) > 0 {
 		parametersFromNames, err := getJsonSSMParameters(names, strict)
@@ -198,9 +196,7 @@ func getAllParameters(names, paths, plainNames, plainPaths []string, strict, rec
 				log.Fields{"names": names},
 			).Fatal("Can't get parameters by names")
 		}
-		for _, parameter := range parametersFromNames {
-			parameters = append(parameters, parameter)
-		}
+		parameters = append(parameters, parametersFromNames...)
 	}
 	if len(plainPaths) > 0 {
 		parametersFromPlainPaths, err := getPlainSSMParametersByPaths(plainPaths, strict, recursive)
@@ -209,9 +205,7 @@ func getAllParameters(names, paths, plainNames, plainPaths []string, strict, rec
 				log.Fields{"plain_paths": plainPaths},
 			).Fatal("Can't get plain parameters by paths")
 		}
-		for _, parameter := range parametersFromPlainPaths {
-			parameters = append(parameters, parameter)
-		}
+		parameters = append(parameters, parametersFromPlainPaths...)
 	}
 
 	if len(plainNames) > 0 {
@@ -221,9 +215,7 @@ func getAllParameters(names, paths, plainNames, plainPaths []string, strict, rec
 				log.Fields{"plain_names": plainNames},
 			).Fatal("Can't get plain parameters by names")
 		}
-		for _, parameter := range parametersFromPlainNames {
-			parameters = append(parameters, parameter)
-		}
+		parameters = append(parameters, parametersFromPlainNames...)
 	}
 
 	return