JS Tidy-ups #53
Description
In response to #52, @liamjohnston raised a couple of changes that would modernize/tidy-up the JS stuff a bit
Keeping these for a subsequent release for now
There's a few things we'd do differently if we were building this now/ourselves. Up to you if you want to tackle any of them though:
- keyCode is deprecated (see https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode)
- we prefer to use myEl.getAttribute('data-whatever') over myEl.dataset.whatever, since you can search the code and find the references more easily.
- typescript would be nice, but obvs that's a bit more work.
- ditto removing reliance on jquery (unless this also deals with jquery plugins?).