Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current directory check does not work with symbolic links #206

Open
OuyeXie opened this issue Mar 21, 2018 · 1 comment
Open

Current directory check does not work with symbolic links #206

OuyeXie opened this issue Mar 21, 2018 · 1 comment

Comments

@OuyeXie
Copy link

OuyeXie commented Mar 21, 2018

The line above gets the canonical path of the file and this check will break when "file" is a symbolic link .

My example:

  • file abs: /local/asdf/_env/asdf-swit1na.18021267.375759313.1848829265/static-content/templates/asdf.html.mustache
  • parent abs: /local/asdf/package/local_1/Generic/asdf/asdf-441.0-0/static-content/templates/asdf html.mustache
  • checkRoot abs: /local/asdf/_env/asdf-swit1na.18021267.375759313.1848829265

And under directory: /local/apollo/_env/asdf-swit1na.18021267.375759313.1848829265

  • static-content -> ../../package/local_1/Generic/asdf/asdf-441.0-0/static-content
@spullara
Copy link
Owner

Hmmm. I'll take a look if there is another way to safely check that they aren't escaping the root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants