sqlcipher_export() behaviour with existing output file

[finiasz]

Expected Behavior

When running an sqlcipher_export() command, if the output file already exists, I would expect the command to either completely overwrite the content of the database, or fail with an exception. Failing with an exception seems to be the safe choice.

Actual Behavior

Current implementation does not fail, but also does not copy the database content. It is not completely clear to me what the operation does, but it looks like the content of the existing file remains untouched.

Steps to Reproduce

SQLCipher version (can be identified by executing PRAGMA cipher_version;): 4.5.6 community

SQLCipher for Android version: 4.5.6

Are you able to reproduce this issue within the SQLCipher for Android test suite?

Sorry, I haven't tried that yet, but there is no reason why it should not be reproducible.

[sjlombardo]

Hello @finiasz - sqlcipher_export does trigger an error if it is unable to copy the data into the target database. This is not based on whether the file exists, but on whether it is able to copy the database objects and data into the target. If there are collisions (e.g. the target database already has a table of the same name) then an error occurs.

If you are not seeing this behavior, please make a reproduction in the test suite so we can investigate further.