build: Switch to maven publish plugin for publishing (#96)

* Update to Gradle 8.7

* Switch to develocity

* Switch to maven publish plugin for publishing

* Update CI

* Doesn't work with CC yet

* Remove comments

* test: update test task dependency

* fix: get publishing working.

---------

Co-authored-by: Tony Robalik <trobalik@squareup.com>

Author: ZacSweers

.github/workflows/publish.yml

@@ -36,7 +36,7 @@ jobs:
       - name: Publish artifacts
         uses: gradle/gradle-build-action@v2
         with:
-          arguments: publishToMavenCentral -s
+          arguments: publishAllPublicationsToMavenCentralRepository --no-configuration-cache
         env:
           ORG_GRADLE_PROJECT_mavenCentralUsername: ${{ secrets.SONATYPE_NEXUS_USERNAME }}
           ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.SONATYPE_NEXUS_PASSWORD }}

app/build.gradle

@@ -2,6 +2,7 @@ import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
 
 plugins {
   id 'com.squareup.app'
+  alias(libs.plugins.mavenPublish)
 }
 
 application {
@@ -54,10 +55,6 @@ publishing {
       artifactId = 'sort-gradle-dependencies-dist'
       artifact shadowDistZip
     }
-    app(MavenPublication) {
-      artifactId = 'sort-gradle-dependencies-app'
-      from components['java']
-    }
   }
   repositories {
     maven {

app/gradle.properties

@@ -0,0 +1,3 @@
+POM_ARTIFACT_ID=sort-gradle-dependencies-app
+POM_NAME=Gradle Dependencies Sorter
+POM_DESCRIPTION=Sorts Gradle dependencies

build-logic/build.gradle

@@ -23,6 +23,7 @@ gradlePlugin {
 dependencies {
   implementation libs.kotlin.gradle.plugin
   implementation libs.shadow.gradle.plugin
+  implementation libs.maven.publish.plugin
 
   implementation(libs.okhttp3) {
     because('Closing and releasing Sonatype Nexus staging repo')

build-logic/src/main/kotlin/com/squareup/convention/BaseConvention.kt

@@ -14,13 +14,11 @@ class BaseConvention : Plugin<Project> {
     with(pluginManager) {
       apply("org.jetbrains.kotlin.jvm")
       apply("groovy")
-      apply("maven-publish")
-      apply("org.gradle.signing")
     }
 
     // These are set in the base project's gradle.properties
     group = providers.gradleProperty("GROUP").get()
-    version = providers.gradleProperty("VERSION").get()
+    version = providers.gradleProperty("VERSION_NAME").get()
 
     val versionCatalog = extensions.getByType(VersionCatalogsExtension::class.java).named("libs")
     val javaVersion = versionCatalog.findVersion("java").orElseThrow().requiredVersion
@@ -55,4 +53,4 @@ class BaseConvention : Plugin<Project> {
       add("testImplementation", versionCatalog.findLibrary("truth").orElseThrow())
     }
   }
-}
+}

build-logic/src/main/kotlin/com/squareup/convention/LibConvention.kt

@@ -16,11 +16,5 @@ class LibConvention : Plugin<Project> {
 
   override fun apply(target: Project): Unit = target.run {
     pluginManager.apply(BaseConvention::class.java)
-
-    extensions.configure(JavaPluginExtension::class.java) { j ->
-      // We specifically don't want either of these artifacts on the app project
-      j.withJavadocJar()
-      j.withSourcesJar()
-    }
   }
 }

build-logic/src/main/kotlin/com/squareup/convention/PluginConvention.kt

@@ -31,4 +31,4 @@ class PluginConvention : Plugin<Project> {
 
     Publishing.setup(this)
   }
-}
+}

build-logic/src/main/kotlin/com/squareup/convention/publishing/Publishing.kt

@@ -1,123 +1,21 @@
 package com.squareup.convention.publishing
 
-import nexus.Credentials
-import nexus.NexusPublishTask
+import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import org.gradle.api.Project
-import org.gradle.api.publish.PublishingExtension
 import org.gradle.api.publish.maven.MavenPom
-import org.gradle.api.publish.maven.MavenPublication
-import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
-import org.gradle.plugins.signing.Sign
-import org.gradle.plugins.signing.SigningExtension
 
-@Suppress("UnstableApiUsage")
 internal object Publishing {
 
   fun setup(project: Project): Unit = project.run {
-    val isSnapshot = version.toString().endsWith("SNAPSHOT")
-    val isRelease = !isSnapshot
-    val publishing = extensions.getByType(PublishingExtension::class.java)
-    val signing = extensions.getByType(SigningExtension::class.java)
-    val credentials = Credentials(this)
-
-    publishing.repositories { r ->
-      if (credentials.isValid()) {
-        r.maven { a ->
-          a.name = "sonatype"
-
-          val releasesRepoUrl = "https://s01.oss.sonatype.org/service/local/staging/deploy/maven2"
-          val snapshotsRepoUrl = "https://s01.oss.sonatype.org/content/repositories/snapshots"
-          a.url = project.uri(if (isSnapshot) snapshotsRepoUrl else releasesRepoUrl)
-
-          a.credentials {
-            it.username = credentials.username()
-            it.password = credentials.password()
-          }
-        }
-      }
-    }
-
-    afterEvaluate {
-      publishing.publications.all { pub ->
-        // https://github.com/vanniktech/gradle-maven-publish-plugin/blob/462c3b13579929a1ca92343099659866f8081600/plugin/src/main/kotlin/com/vanniktech/maven/publish/MavenPublishBaseExtension.kt#L141C42-L147
-        val key = providers.gradleProperty("signingInMemoryKey").orNull
-        if (key != null) {
-          val keyId = providers.gradleProperty("signingInMemoryKeyId").orNull
-          val pw = providers.gradleProperty("signingInMemoryKeyPassword").getOrElse("")
-          signing.useInMemoryPgpKeys(keyId, key, pw)
-        }
-
-        signing.sign(pub)
-
-        signing.isRequired = isRelease && gradle.taskGraph.allTasks.any { it is PublishToMavenRepository }
-
-        if (pub is MavenPublication) {
-          setupPom(pub.pom)
-        }
-      }
-    }
-
-    val promoteTask = tasks.register("promote", NexusPublishTask::class.java) {
-      with(it) {
-        // only promote non-snapshots
-        onlyIf { !isSnapshot }
-        inputs.property("version", version)
-        configureWith(credentials)
-      }
-    }
-
-    tasks.withType(Sign::class.java).configureEach {
-      with(it) {
-        notCompatibleWithConfigurationCache("https://github.com/gradle/gradle/issues/13470")
-        // only sign non-snapshots
-        onlyIf { !isSnapshot }
-        inputs.property("version", version)
-      }
-    }
-
-    tasks.withType(PublishToMavenRepository::class.java).configureEach {
-      with(it) {
-        notCompatibleWithConfigurationCache("https://github.com/gradle/gradle/issues/13470")
-
-        // Releases require the checks to pass
-        if (!isSnapshot) {
-          dependsOn("check")
-        }
-      }
-    }
-
-    tasks.register("publishToMavenCentral") {
-      with(it) {
-        notCompatibleWithConfigurationCache("Publishing is not compatible")
-        finalizedBy(promoteTask)
-        dependsOn(tasks.withType(PublishToMavenRepository::class.java))
-
-        group = "publishing"
-        description = "Publishes final artifacts to Maven Central"
-
-        doLast {
-          if (isSnapshot) {
-            logger.quiet("Browse files at https://s01.oss.sonatype.org/content/repositories/snapshots/com/squareup/")
-          } else {
-            logger.quiet("If 'promote' task failed: after publishing to Sonatype, visit https://s01.oss.sonatype.org to close and release from staging")
-          }
-        }
-      }
+    project.pluginManager.withPlugin("com.vanniktech.maven.publish") {
+      extensions.getByType(MavenPublishBaseExtension::class.java).pom(::setupPom)
     }
   }
 
   private fun setupPom(pom: MavenPom): Unit = pom.run {
     name.set("Gradle Dependencies Sorter")
     description.set("Sorts Gradle dependencies")
-    url.set("https://github.com/square/gradle-dependencies-sorter")
-    inceptionYear.set("2022")
 
-    licenses {
-      it.license { l ->
-        l.name.set("The Apache License, Version 2.0")
-        l.url.set("https://www.apache.org/licenses/LICENSE-2.0.txt")
-      }
-    }
     developers {
       it.developer { d ->
         d.id.set("autonomousapps")
@@ -132,10 +30,5 @@ internal object Publishing {
         d.name.set("Jason Holmes")
       }
     }
-    scm {
-      it.connection.set("scm:git:git://github.com/square/gradle-dependencies-sorter.git")
-      it.developerConnection.set("scm:git:ssh://github.com/square/gradle-dependencies-sorter.git")
-      it.url.set("https://github.com/square/gradle-dependencies-sorter")
-    }
   }
 }