Added tests for git url transforms

Author: handstandsam

invert-gradle-plugin/build.gradle.kts

@@ -38,6 +38,8 @@ dependencies {
 
     implementation(libs.kotlinx.serialization.json)
     implementation(libs.kotlinx.coroutines.core)
+
+    testImplementation(libs.kotlin.test)
 }
 
 kotlin {

invert-gradle-plugin/src/main/kotlin/com/squareup/invert/internal/GitDataCollector.kt

@@ -11,6 +11,8 @@ import java.io.IOException
  */
 internal object GitDataCollector {
 
+  private const val GIT_EXTENSION = ".git"
+
   fun currentBranch(): GitBranch {
     return exec("git rev-parse --abbrev-ref HEAD").stdOut.lines()[0]
   }
@@ -32,16 +34,19 @@ internal object GitDataCollector {
         it
       }
     }.map {
-      val gitExtension = ".git"
-      if (it.endsWith(gitExtension)) {
-        it.substring(0, it.length - gitExtension.length)
+      if (it.endsWith(GIT_EXTENSION)) {
+        it.substringBeforeLast(GIT_EXTENSION)
       } else {
         it
       }
     }.map {
-      buildString {
-        append("https://")
-        append(it.replace(":", "/"))
+      if (!it.startsWith("https://")) {
+        buildString {
+          append("https://")
+          append(it.replace(":", "/"))
+        }
+      } else {
+        it
       }
     }[0]
   }

invert-gradle-plugin/src/test/kotlin/GitDataCollectorTest.kt

@@ -0,0 +1,50 @@
+package com.squareup.invert.internal
+
+import com.squareup.invert.internal.exec
+import com.squareup.invert.models.GitBranch
+import com.squareup.invert.models.GitSha
+import org.gradle.api.GradleException
+import org.gradle.api.logging.Logger
+import org.junit.Test
+import java.io.IOException
+import kotlin.test.assertEquals
+
+/**
+ * Executes `git` commands and parses the output.
+ */
+class GitDataCollectorTest {
+
+  @Test
+  fun testOrgAtGit() {
+    val actual = GitDataCollector.remoteRepoGitUrlToHttps(
+      "org-123@github.com:company/my-repo.git"
+    )
+    assertEquals(
+      expected = "https://github.com/company/my-repo",
+      actual = actual
+    )
+  }
+
+  @Test
+  fun testHttpsDotGit() {
+    val actual = GitDataCollector.remoteRepoGitUrlToHttps(
+      "git@github.com:square/invert.git"
+    )
+    assertEquals(
+      expected = "https://github.com/square/invert",
+      actual = actual
+    )
+  }
+
+
+  @Test
+  fun testHttps() {
+    val actual = GitDataCollector.remoteRepoGitUrlToHttps(
+      "https://github.com/company/my-repo"
+    )
+    assertEquals(
+      expected = "https://github.com/company/my-repo",
+      actual = actual
+    )
+  }
+}