Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric edition is not configurable #88

Closed
James-E-A opened this issue Jan 20, 2021 · 5 comments
Closed

Fabric edition is not configurable #88

James-E-A opened this issue Jan 20, 2021 · 5 comments

Comments

@James-E-A
Copy link

When I switched from Forge to Fabric, I noticed that AppleSkin seemed to be ignoring its config file now. (In particular, showFoodValuesHudOverlay is ignored.)

I tried copying the file config/appleskin-client.toml to config/fabric/appleskin-client.toml, but that did not fix it.

Is there something else that needs to be done to configure the Fabric edition (in which case I'll happily send a PR to update the documentation), or is this a bug in the code?

@squeek502
Copy link
Owner

The Fabric version isn't configurable yet. Been something I've been meaning to do for a while, but haven't gotten around to it. Related: #85

@squeek502 squeek502 changed the title Fabric edition ignores config Fabric edition is not configurable Jan 20, 2021
@Lv44EnderShaman
Copy link

I'm glad this is something in progress, because it was a concern of mine for a while starting to use it on Fabric compared to Forge. If there's anything a contributor can do to help, let it be known; it's always handy to lift a burden off of someone when they need it.

@SAGESSE-CN
Copy link
Contributor

@squeek502 In Fabric use the JSON to configure the implementation, is right?

@squeek502
Copy link
Owner

squeek502 commented May 24, 2021

I think for Fabric the standard is to use Cloth + AutoConfig:

SAGESSE-CN added a commit to SAGESSE-CN/AppleSkin that referenced this issue May 25, 2021
@squeek502
Copy link
Owner

Config added in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants